Jon Atack comments

Results 455 comments of


                                            Jon Atack

doc: update -loglevel help to add `info` to the always logged levels

Re-pushed to provide the accepted log levels and the always-logged ones in the same order of severity (descending).

doc: Add missing backtick in developer notes logging section

ACK c003562120c193c296ac754b4bb8cff02bbbe4dc Tangential, I don't understand the macro ordering in this line: ``` The macros `LogInfo`, `LogDebug`, `LogTrace`, `LogWarning` and `LogError` are available for ```

[25.x] Backports

#29200 would be relevant.

logging: Update to new logging API

I don't think updating all the macros is a good idea until the API is finished.

ci: failure in `wallet_assumeutxo.py --descriptors`

Thanks for reporting. Ran into it as well. https://github.com/bitcoin/bitcoin/actions/runs/7492061657/job/20394747721?pr=29230#step:27:7866

refactor: extract CCheckQueue's data handling into a separate container "Bag"

ACK 6a9c6ea9734854a2438d180ae13f123170e96d4c

cli: rework -addrinfo cli to use addresses which aren’t filtered for quality/recency

> ping @jonatack, could you have a look, especially at the changes to bitcoin-cli? Thanks! Sorry for missing the ping and not looking sooner. (@stratospher please ping me when you...

cli: rework -addrinfo cli to use addresses which aren’t filtered for quality/recency

@stratospher Referencing the review feedback in https://github.com/bitcoin/bitcoin/pull/26988#discussion_r1145326660, the argument about complexity doesn't outweigh that, and less so when there are simple alternatives that have been proposed. If this were to...

cli: rework -addrinfo cli to use addresses which aren’t filtered for quality/recency

> simply [reports an error](https://github.com/bitcoin/bitcoin/blob/aebfac13443c2abf78ebd88cd1f41213ca79ce5a/src/bitcoin-cli.cpp#L273) in case an older version of bitcoind is used with a newer bitcoin-cli That's not helpful to someone with a long-running older node (say, for...

logging: use bitset for categories

Given that performance and benchmarks have been a key part of the discussion, #26957 has updated benchmarks that reviewers may use for evaluating this pull and #26619. I'm currently rebasing...