Jon Atack
Jon Atack
Concept ACK, will look more deeply.
> All consistent, now accepting the same parameters > All compatible with log categories, to make it possible to filter or highlight log messages from a particular component > All...
> Curious, when you say "over-complicated", are you referring to the implementation of the logging code, or to the usage of the logging API? Or to effects of logging settings?...
Concept ACK. (Maybe unrelated, but the Win64 CI task is one I've often wished for more debug info from when a unit test fails.)
> Not sure. Seems better to be consistent. These aren't "unknown messages", though, so it could be reasonable to treat them differently.
> The details are already logged at the beginning of the connection Can drop the log improvement if people prefer, but it provides info not in the connection log. In...
- The test changes seems sporadic (and often pass on master for me locally) - Would 15970699828fa404a0c7c17bda4640eb712872a7 disable our inbound onion detection? (`CNode::m_inbound_onion` in `net.h`)