Jon Atack

Thanks for the PR @justinmoon. Happy to review and merge any other proposals you have.

Thanks @michaelfolkson! Feel free to propose additions and improvements. I see this as a WIP that is temporarily incubated here but intended to be published more officially at some point...

Concept ACK A few suggestions for your consideration ```diff diff --git a/src/rpc/rawtransaction.cpp b/src/rpc/rawtransaction.cpp index b6715f7f20..1ccc267ec1 100644 --- a/src/rpc/rawtransaction.cpp +++ b/src/rpc/rawtransaction.cpp @@ -164,7 +164,7 @@ static std::vector CreateTxDoc() // Update PSBT...

Review ACK 07df6cda1468ed45ac227ac6f0169b040e5c0bf3

Post-merge ACK

Thanks for updating, re-reviewing.

Will have a look! > It may be desirable to have this in 24.0, feature freeze in mid August

Been running this branch for a couple days and haven't noticed any issues. ``` 2022-07-24T13:39:38Z [i2p] Creating transient SAM session with 127.0.0.1:7656 2022-07-24T13:40:18Z [i2p] transient SAM session created: session id=1386b9ab4d,...

ACK acae0543fc8fb7954eadbd7019e446f31112211e suggestions: - https://github.com/bitcoin/bitcoin/pull/25355#discussion_r933384769 - commit message "i2p: log the session id in the "Creating seesion" message" -> "session" - squash or drop the small style commits > >...

Concept ACK, a few quick thoughts before reviewing: - debug build clean and local tests green - the help in `bitcoin-cli help migratewallet` is pretty sparse? -- could benefit from...