Jon Atack

logging: add `-loglevel` configuration option and a `trace` log level

5

These are the next steps in parent PR #25203 implementing, with Klement Tan, an idea by John Newbery and refined in GitHub discussions by Wladimir Van der Laan and Marco...

ECL regression since deleting support for top-level assertions

5

[CL-Kraken](https://github.com/jonatack/cl-kraken/) uses Rove for testing SBCL, CCL, CLISP, ABCL and ECL since early this year (2019). Commit 8859b0a seems to have caused a bug when used with ECL 16.1.3. The...

rpc, cli: getpeerinfo and -netinfo updates

4

Various updates and fixups, mostly targeting v24. Please refer to the commit messages for details.

Severity-based logging -- parent PR

11

This is a parent PR for continuing updates to severity-based logging. See https://github.com/bitcoin/bitcoin/issues/20576 for motivation and https://github.com/bitcoin/bitcoin/pull/25306 for discussion. Several of the initial changes here have been merged. The current...

p2p: always provide CNodeStateStats and getpeerinfo/netinfo/gui updates

24

- update CNodeStateStats members to be std::optional or member-initialized with default values - return CNodeStateStats and NodeStats directly rather than a bool - make some getpeerinfo and gui peers fields...

Use fallback value for Version and User Agent during peer connection

1

During connection setup for a peer, getpeerinfo returns `"version": 0, "subver": ""` and the GUI Peers window displays 0 and an empty field, respectively. Give these fields the same behavior...

to current v24.0 p2p behavior. Similar updates have been made to RPC getpeerinfo and CLI -netinfo.

test: create random and coins utils, add amount helper, dedupe add_coin

5

- Move random test utilities from `setup_common` to a new `random` file, as many tests don't use this code. - Create a helper to generate semi-random CAmounts for a full...

Add cs_main annotation to WriteBatchSync(), drop lock in CDiskBlockIndex

10

Addresses review feedback by Marco Falke in https://github.com/bitcoin/bitcoin/pull/22932#discussion_r794493058: 1. add `cs_main` thread safety annotation to `CBlockTreeDB::WriteBatchSync()`, which allows us to 2. remove the `cs_main` lock in `CDiskBlockIndex::SERIALIZE_METHODS` with respect to...

refactor: move index class members from protected to private

15

Simplify the index base and child classes and improve encapsulation and clarity by making fully overridden virtual member functions `private`. In the child classes, this allows having only public and...