Jon Atack comments

Results 455 comments of


                                            Jon Atack

net, cli: use v2transport for manual/addrfetch connections, add to -netinfo

Reviewed https://github.com/bitcoin/bitcoin/commit/fb5bfed26a564014b83ccfc96ff00b630930fc61; WIP review of the other two commits.

sync: introduce a thread-safe generic container and use it to remove a bunch of "GlobalMutex"es

Light Approach ACK after reading the code and the excellent review discussions. It looks like this has been progressively honed and improved quite a bit. Will test and review.

sync: introduce a thread-safe generic container and use it to remove a bunch of "GlobalMutex"es

Will review the updates since my initial ACK https://github.com/bitcoin/bitcoin/pull/25390#pullrequestreview-1390434676.

wallet, rpc: document and update `sendall` behavior around unconfirmed inputs

The code changes cause this test failure for me locally: ``` $ ./test/functional/wallet_fundrawtransaction.py --legacy-wallet 2023-11-30T23:17:02.968000Z TestFramework (INFO): PRNG seed is: 4425912909580482609 .../... 2023-11-30T23:17:20.070000Z TestFramework (INFO): Test fundrawtxn with locked wallet...

validation: improve performance of CheckBlockIndex

Concept ACK

validation: log which peer sent us a header

Concept ACK

wallet: avoid returning a reference to vMasterKey after releasing the mutex that guards it

> > Let me know if I should drop it and you prefer to keep it here > > It is ok. I don't have a preference whether it gets...

RPC/Wallet: Add "use_txids" to output of getaddressinfo

Needs rebase/update.

test: add end-to-end tests for CConnman and PeerManager

There may be a silent merge conflict. After rebase to current master at fde224a6610699a6a28cc27e299ac14cbf7e16ca, building with Clang 16 fails at commit `test: add a mocked Sock that allows inspecting what...

test: add end-to-end tests for CConnman and PeerManager

ACK 612ba17fcadc955c142f21f9b1af0b60f0def55f