Jon Atack comments

Results 455 comments of


                                            Jon Atack

test/BIP324: functional tests for v2 P2P encryption

Concept ACK

test: create random and coins utils, add amount helper, dedupe add_coin

Updated with feedback from @john-moffett and @fanquake (thanks!)

test: create random and coins utils, add amount helper, dedupe add_coin

Rebased, squashed the money helper changes to one commit, and de-duplicated a shared `add_coin` method by extracting it to a test utility.

test: create random and coins utils, add amount helper, dedupe add_coin

Trivial rebase per `git range-diff 52ddbd5 d34bc34 e6de5ad` for the merge of #26345. Thank you for the ACKs, @john-moffett and @pinheadmz, mind re-ACKing? I don't have a strong opinion on...

test: create random and coins utils, add amount helper, dedupe add_coin

> If a majority of the values are now `0` and `1` Only 1% was 0 and 1% was 1. I liked that it would check edge cases often enough...

test: create random and coins utils, add amount helper, dedupe add_coin

@glozow Thanks for bringing it up! The rationale was in this thread: https://github.com/bitcoin/bitcoin/pull/26940#discussion_r1083532109. I noticed this as well, and that `src/test/util/chainstate.h` has the same dependency, and made a patch to...

test: create random and coins utils, add amount helper, dedupe add_coin

> setup_common can't use any of the random functions without creating a circular dependency Addressed with #27425.

rpc: add path to gethdkey

Thanks for working on this!

rpc: add path to gethdkey

Re-concept ACK (not sure if it's ready for review).

Add cs_main annotation to WriteBatchSync(), drop lock in CDiskBlockIndex

I agree but didn't see how to update the fuzz tests to do it -- happy to update with suggestions.