Markus Elfring

[Extra null pointer checks are not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null) in the member function "[ofApp::unloadTextures](https://github.com/ofZach/inkSpace/blob/5ef1fc3bc3f081bdad760fc71b4e6883155aeb5a/src/ofApp.cpp#L975)".

Some parameters (like "[${OPENCL_INCLUDE_DIR}](https://github.com/sithhell/oclm/blob/be04cfdea09df68c15bbebed06f89a0fe43c184b/CMakeLists.txt#L27)" and "[${CMAKE_SOURCE_DIR}/src/context.cpp](https://github.com/sithhell/oclm/blob/92937037375bb94176a48e025eac8fc072302f63/src/CMakeLists.txt#L47)") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build...

Completion of error handling

3

Would you like to add more error handling for return values from functions like the following? * [fclose](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html "Close a stream") ⇒ [_synctex_updater_close](https://github.com/jlaurens/synctex/blob/91d69b73e2fc9c65953c04debe0f06fbd1e51299/synctex_parser.c#L8491) * [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [_synctex_log](https://github.com/jlaurens/synctex/blob/c3ae46d28d9068d56f781d7e10ca25f0fc5dff20/synctex_parser_utils.c#L105)

[An extra null pointer check is not needed](https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first "Free a null pointer anyway or check first?") in [the function “_synctex_free”](https://github.com/jlaurens/synctex/blob/c3ae46d28d9068d56f781d7e10ca25f0fc5dff20/synctex_parser_utils.c#L79 "Update candidate").

I would like to point out that identifiers like “[`__SYNCTEX_PARSER__`](https://github.com/jlaurens/synctex/blob/c11fe00dbdc6423a0e54d4e531563be645f78679/synctex_parser.h#L50 "Update candidate")” and “[`__synctex_scanner_free_handle`](https://github.com/jlaurens/synctex/blob/91d69b73e2fc9c65953c04debe0f06fbd1e51299/synctex_parser.c#L851 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the...

Would you like to add the configuration script "[AX_PTHREAD](https://www.gnu.org/software/autoconf-archive/ax_pthread.html)" to [your build specification](https://github.com/panyam/KafkaLite/blob/49c2afd07f7e0afe655d487518382b218f50981b/configure.ac#L26)?

Completion of error handling

2

Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [kl_context_open](https://github.com/panyam/KafkaLite/blob/d900a09f482bb0bcf2f3f3f86035e344b4a33ad5/src/klcontext.c#L6) - [pthread_mutex_init](http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_mutex_init.html) ⇒ [kl_pthread_mutex_new](https://github.com/panyam/KafkaLite/blob/5ae821843140881faa529f94c877680aebce2dd9/src/klpthreadmutex.c#L5)

reserved identifier violation

3

I would like to point out that identifiers like “[`__initialize_egl_h__`](https://github.com/Igalia/WPEBackend-fdo/blob/0e10c424223dbc663ea6f4f2f299c99cd4e14718/include/wpe/initialize-egl.h#L30 "Update candidate")” and “[`__wpe_fdo_h__`](https://github.com/Igalia/WPEBackend-fdo/blob/0e10c424223dbc663ea6f4f2f299c99cd4e14718/include/wpe/fdo.h#L30 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...

:thought_balloon: Would you like to [wrap any pointer data members](https://github.com/trialuser02/qt6ct/blob/14a8f91a48b2769425da0b26f05a9ec3a641cc1e/src/qt6ct/appearancepage.cpp#L45 "Update candidate: AppearancePage class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?

Improve exception safety with smart pointers

1

Would you like to [wrap any pointer data members](https://github.com/ColumbusUtrigas/ColumbusEngine/blob/d0c25a16c81ce17e81c51f33b861eb8541095691/Physics/PhysicsWorld.cpp#L7 "Update candidate: PhysicsWorld class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?