Markus Elfring

Make place-holder usage consistent

3

I wonder a bit about the different usage of place-holders in [the provided udev rule file](https://github.com/twaugh/system-config-printer/blob/aa74679257e8822f3b855b62d1476933a016f828/udev/70-printers.rules#L1). - Is it important to express that only two characters may follow a known...

Would you like to add more error handling for return values from functions like the following? - [ippNewRequest](https://www.cups.org/documentation.php/doc-2.0/api-httpipp.html#ippNewRequest) ⇒ [find_matching_device_uris](https://github.com/twaugh/system-config-printer/blob/8459b61f069bb6967c0d19e69481074c44d56b94/udev/udev-configure-printer.c#L986) - [strdup](http://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html) ⇒ [add_usb_uri_mapping](https://github.com/twaugh/system-config-printer/blob/8459b61f069bb6967c0d19e69481074c44d56b94/udev/udev-configure-printer.c#L242)

[The software combination “GNU make 4.3”](https://lists.gnu.org/archive/html/info-gnu/2020-01/msg00004.html "Release of GNU make 4.3") supports [build rules for grouped targets](https://www.gnu.org/software/make/manual/html_node/Multiple-Targets.html#Rules-with-Grouped-Targets "Rules with grouped targets"). Would you like to [adjust your current make script...

[The make script](https://github.com/ocaml/ocamlbuild/blob/7115a9441ed11a736834305ea17a42ab1f251a4d/Makefile#L1 "Update candidate") which was used so far contained restrictions for storage locations according to the combination of source files and the corresponding generation of further file variants....

Support for out-of-source builds by make scripts of this software

19

How do you think about to benefit from [parallel build trees](https://www.gnu.org/software/automake/manual/html_node/VPATH-Builds.html) also for your software? Would you like to [support out-of-source](https://cmake.org/Wiki/CMake_FAQ#What_is_an_.22out-of-source.22_build.3F) ([VPATH](https://www.gnu.org/software/make/manual/html_node/General-Search.html)) builds?

Using two temporary directories for the generation of “ocamlbuild_pack.cm*”

1

The directory “tmp” is created by two recipes in [the make script](https://github.com/ocaml/ocamlbuild/blob/7115a9441ed11a736834305ea17a42ab1f251a4d/Makefile#L151 "Update candidate") which is used so far. I imagine that this approach can become insufficient in the use...

Checking build commands for the usage of “Ocamlbuild_pack.Main”

2

The source file “ocamlbuild.ml” is not explicitly mentioned in [the make script](https://github.com/ocaml/ocamlbuild/blob/7115a9441ed11a736834305ea17a42ab1f251a4d/Makefile#L92 "Update candidate") which is used so far. By which compilation command can [the reference “Ocamlbuild_pack.Main”](https://github.com/ocaml/ocamlbuild/blob/6a7311b74a639f77868f8c2d25d74c46763bee24/src/ocamlbuild.ml#L17 "Calling the main...

Avoid manual repetition of suffixes in a make script

4

A suffix like “cmo” is repeated several times for [the definition of two variables](https://github.com/ocaml/ocamlbuild/blob/7115a9441ed11a736834305ea17a42ab1f251a4d/Makefile#L36 "Update candidate"). I suggest to avoid this. * [The function “addsuffix”](https://www.gnu.org/software/make/manual/html_node/File-Name-Functions.html#index-addsuffix "Appending a suffix automatically") can...

Completion of error handling

2

Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [gdi_init](https://github.com/ctxis/RDP-Replay/blob/25e20be46d58fd079b4c5a1cdfef76d807304ce8/libfree_rdp/libfreerdp-gdi/gdi.c#L869) - [pthread_create](http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_create.html) ⇒ [main](https://github.com/ctxis/RDP-Replay/blob/25e20be46d58fd079b4c5a1cdfef76d807304ce8/replay/rdp_replay.C#L70)

Catch exceptions in main()?

1

I expect that exception handling is usually supported by a C++ program. I wonder why your function "[main](https://github.com/ctxis/RDP-Replay/blob/25e20be46d58fd079b4c5a1cdfef76d807304ce8/replay/rdp_replay.C#L70)" does not contain [corresponding try and catch instructions](http://stackoverflow.com/questions/368184/does-it-make-sense-to-catch-exceptions-in-the-main) so far. How do...