Markus Elfring
Markus Elfring
I would like to point out that identifiers like "[`_INTER_PREDICTION_H_`](https://github.com/cisco/thor/blob/f32aef3aeb4648e481e34c0891b5cb64cffcaf46/common/inter_prediction.h#L27)" and "[`_SIMD_H`](https://github.com/cisco/thor/blob/f32aef3aeb4648e481e34c0891b5cb64cffcaf46/common/simd.h#L29)" [do not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C language standard. Would you like to adjust...
Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [thor_alloc](https://github.com/cisco/thor/blob/f32aef3aeb4648e481e34c0891b5cb64cffcaf46/common/simd.h#L108) - [fseek](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fseek.html) ⇒ [main](https://github.com/cisco/thor/blob/d7f84d9e2ac0bbf226284f2f29828fccc807695f/enc/mainenc.c#L72)
Would you like to replace more defines for constant values by [enumerations](https://en.wikipedia.org/wiki/Enumerated_type#C_and_syntactically_similar_languages) to stress their relationships? - [ICELIB_…_WEIGHT](https://github.com/cisco/NATTools/blob/dadc20e10c348d1ba6de8736d71f442e88551eba/icelib/include/icelib_defines.h#L54) - [STUN_ATTR_…](https://github.com/cisco/NATTools/blob/1332849a86c9460f1e3fe0154286ecb02652d531/stunlib/include/stunlib.h#L95)
[Augmented assignment statements became available with Python 2](https://docs.python.org/3/whatsnew/2.0.html#augmented-assignment "Augmented assignments"). :thought_balloon: Thus improve 12 source code places accordingly.
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
[The command “`mkdir -p /tmp/a/b/c`” can be a known example](https://en.wikipedia.org/wiki/Mkdir#Options "Creating directories") for the creation of directories. I am looking for programming interfaces which can provide similar functionality for trees....
Would you like to add more error handling for return values from functions like the following? * [fclose](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html "Close a stream") ⇒ [PMMG_saveGraph](https://github.com/MmgTools/ParMmg/blob/346471ccc49d6a9cf1d2b61e6d5d8038c1eb39cb/src/metis_pmmg.c#L114) * [fprintf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html "Print formatted output") ⇒ [main](https://github.com/MmgTools/ParMmg/blob/62caef1b9f003da70ce7c123f7d4bb7210594ee9/scripts/genheader.c#L79)
I would like to point out that identifiers like “[`_LIBPARMMGTYPES_H`](https://github.com/MmgTools/ParMmg/blob/62caef1b9f003da70ce7c123f7d4bb7210594ee9/src/libparmmgtypes.h#L32 "Update candidate")” and “[`_PARMMG_H`](https://github.com/MmgTools/ParMmg/blob/346471ccc49d6a9cf1d2b61e6d5d8038c1eb39cb/src/parmmg.h#L33 "Another update candidate")” [do eventually not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for...
Would you like to add more error handling for return values from functions like the following? - [printf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html) ⇒ [DHTKey::RMDstring](https://github.com/beniz/seeks/blob/1168b3a2f3111c3fca31dd961135194c3e8df5fd/src/dht/DHTKey.cpp#L371) - [strdup](http://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html) ⇒ [main](https://github.com/beniz/seeks/blob/9a74a298dde8706055859cc45a3708bb9a881610/src/seeks.cpp#L153)
I have seen that [no loop is used around a call](https://github.com/beniz/seeks/blob/1168b3a2f3111c3fca31dd961135194c3e8df5fd/src/plugins/cf/rank_estimators.cpp#L779) of the function "[cond_wait](https://github.com/beniz/seeks/blob/1168b3a2f3111c3fca31dd961135194c3e8df5fd/src/utils/mutexes.cpp#L87)". Would you like to reuse anything from my message on the topic "[spurious wakeup](http://groups.google.de/group/comp.programming.threads/msg/bb8299804652fdd7)"?