Markus Elfring
Markus Elfring
Would you like to add the configuration script "[AX_PTHREAD](https://www.gnu.org/software/autoconf-archive/ax_pthread.html)" to [your build specification](https://github.com/beniz/seeks/blob/47eb1666d7ad08dc6441e401acb80ef21c97f5fc/configure.in#L246)?
Would you like to [replace any double quotes](https://github.com/beniz/hmdp/blob/23673cf49f4bfff7acd780c6f38093d9a1e92f17/src/engine/HmdpEngine.h#L20) by [angle brackets around file names for include statements](http://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename)?
The functions "[exit](http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html)" and "[fclose](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html)" do not belong to the list of [async-signal-safe functions](https://www.securecoding.cert.org/confluence/display/c/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers). I guess that a different program design will be needed for your function "[signal_callback_handler](https://github.com/bentiss/hid-replay/blob/78754c07ad452a02509cd9e2370eb14cd78241ea/src/hid-replay.c#L436)".
Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [find_hid_dbg](https://github.com/bentiss/hid-replay/blob/3f1c129eabb3f705d156c8c39ae3b14232572e8d/src/hid-recorder.c#L221) - [signal](http://pubs.opengroup.org/onlinepubs/9699919799/functions/signal.html) ⇒ [main](https://github.com/bentiss/hid-replay/blob/78754c07ad452a02509cd9e2370eb14cd78241ea/src/hid-replay.c#L445)
I would like to point out that an identifier like “[`IGNITION__RVIZ__PLUGINS__IMAGEDISPLAY_HPP_`](https://github.com/gazebosim/gz-rviz/blob/eecb9b006eceb28e62571b566bae24a9c29f4216/ign_rviz_plugins/include/ignition/rviz/plugins/ImageDisplay.hpp#L15 "Update candidate")” [does not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the...
[An extra null pointer check is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null) in [the destructor for the class "TSmartMemory"](https://github.com/MicrosoftEdge/WebGL/blob/a46127871f780ea22d75218004b057e774a03051/core/include/SmartMemory.hxx#L51).
Would you like to add more error handling for return values from functions like the following? - [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [main](https://github.com/westerndigitalcorporation/dm-zoned-tools/blob/ccad5c7316e57c90392cb75329a44f04b222391e/src/dmzadm.c#L152) - [printf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html "Print formatted output") ⇒ [dmz_print_zone](https://github.com/westerndigitalcorporation/dm-zoned-tools/blob/155430ad1ede67598557f9dfb7f76d5906fa67fd/src/dmz_dev.c#L284)
The statement “`print_error("Memory Allocation problem");`” is specified in three branches for the implementation of the function “[verify_write](https://github.com/westerndigitalcorporation/ufs-utils/blob/72c80141450252314f1be69c079079f2e043e255/options.c#L730 "Update candidate")”. I find that the message should be sufficient at one source...
[An extra null pointer check is not needed](http://dietmar-kuehl.de/mirror/c++-faq/freestore-mgmt.html#faq-16.8) in [the destructor for the class "JabberService"](https://github.com/LubosD/twinkle/blob/42678b3346f05c3cce3915989b1057785bde989e/src/log.cpp#L97).
I would like to point out that identifiers like "[`_FATRAT_H`](https://github.com/LubosD/fatrat/blob/ccf8d51664d1a9d4a4859e98010917bfb1dc0cdd/src/fatrat.h#L27)" and "[`_SETTINGSDLG_H`](https://github.com/LubosD/fatrat/blob/ccf8d51664d1a9d4a4859e98010917bfb1dc0cdd/src/SettingsDlg.h#L27)" [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C++ language standard. Would you like to adjust...