Markus Elfring
Markus Elfring
I would like to point out that identifiers like "[`__ULINUX_H__`](https://github.com/Juniper/contrail-vrouter/blob/ad423268f5d0caee466e74c7ac5057e502424910/include/ulinux.h#L1)" and "[`__VR_DEFS_H__`](https://github.com/Juniper/contrail-vrouter/blob/ad423268f5d0caee466e74c7ac5057e502424910/include/vr_defs.h#L7)" [do not fit](https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C language standard. Would you like to adjust...
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [LEdge](https://github.com/CGAL/cgal/blob/c68cf8fc4c850f8cd84c6900faa781286a7117ed/Convex_decomposition_3/test/Convex_decomposition_3/edge_sorter.cpp#L24 "Destructor for LEdge") - [Range_tree_1](https://github.com/CGAL/cgal/blob/b9e320659e41c255d82642d03739150779f19575/SearchStructures/include/CGAL/Range_tree_k.h#L97...
Would you like to add more error handling for return values from functions like the following? - [fclose](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html) ⇒ [parse_hedis_config](https://github.com/hedisdb/hedis/blob/1a2ca7b4231fd8c3aa1db20f680c8ebe00100e26/src/hedis.c#L250) - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [build_connector](https://github.com/hedisdb/hedis/blob/1a2ca7b4231fd8c3aa1db20f680c8ebe00100e26/src/hedis.c#L46)
The function "[exit](http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html)" does not belong to the list of [async-signal-safe functions](https://www.securecoding.cert.org/confluence/display/c/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers). I guess that a different program design will be needed for your function "[sigShutdownHandler](https://github.com/hedisdb/hedis/blob/1a2ca7b4231fd8c3aa1db20f680c8ebe00100e26/src/redis.c#L3534)".
**Describe the bug** I would like to build another current version of this software also for my needs. Unfortunately, something hindered me. **Steps To Reproduce** 1. Current contents were retrieved...
Would you like to add more error handling for return values from functions like the following? * [fclose](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html "Close a stream.") ⇒ [TInputFiles::start](https://github.com/gpertea/stringtie/blob/b4366c542af25f9f25e37c434858718d2f757b3c/tmerge.cpp#L119) * [fputs](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fputs.html "Put a string on a...
Would you like to [wrap any member pointers](https://github.com/gpertea/stringtie/blob/b4366c542af25f9f25e37c434858718d2f757b3c/SuperReads_RNA/global-1/quorum/src/mer_database.hpp#L65-L92 "Update candidate: hash_with_quality class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [basic_circular_buffer](https://github.com/gpertea/stringtie/blob/b4366c542af25f9f25e37c434858718d2f757b3c/SuperReads_RNA/global-1/jellyfish/include/jellyfish/circular_buffer.hpp#L59-L62 "Destructor for basic_circular_buffer") - [Value](https://github.com/gpertea/stringtie/blob/b4366c542af25f9f25e37c434858718d2f757b3c/SuperReads_RNA/global-1/jellyfish/lib/jsoncpp.cpp#L2035-L2036...
I would like to point out that an identifier like “[`_DNS_MESSAGE_H`](https://github.com/mnezerka/dnslib/blob/502368b319a2fe3829f48d845768899db39b43a4/src/message.h#L38-L39 "Update candidate")” [does eventually not fit](https://wiki.sei.cmu.edu/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to...
Would you like to [add more error handling](https://github.com/intel/qpl/blob/6e2b851ddaba9090dfec2af37a28df09383a8a4d/tools/ref/ref_scan.c#L119-L120 "Update candidate: own_compare_le_be()") for [return values from a function like malloc()](https://pubs.opengroup.org/onlinepubs/9799919799/functions/malloc.html "Memory allocation")?