Markus Elfring
Markus Elfring
I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing. Would you like to add more error...
I would like to point out that identifiers like "[`_PAYLOAD_`](https://github.com/seL4/camkes/blob/b08cb3b4769dce44de39e10d1c7608c6971e91ba/apps/adder/components/Adder/include/payload.h#L11)" and "[`_SOCKET_`](https://github.com/seL4/camkes/blob/b08cb3b4769dce44de39e10d1c7608c6971e91ba/apps/socket/components/Sender/include/socket.h#L11)" [do not fit](https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C language standard. Would you like to adjust...
[Extra null pointer checks are not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like in [the function “InputBuffer::incrementalHistorySearch”](https://github.com/arangodb/linenoise-ng/blob/master/src/linenoise.cpp#L2387 "Update candidate: InputBuffer::incrementalHistorySearch()").
Would you like to add more error handling for return values from functions like the following? - [calloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/calloc.html "Memory allocation") ⇒ [bitmap_new](https://github.com/stanford-futuredata/sparser/blob/70b2084a009ad235fe4e48c540425bd26edf0def/sparser/bitmap.h#L25) - [sparser_new_query](https://github.com/stanford-futuredata/sparser/blob/70b2084a009ad235fe4e48c540425bd26edf0def/sparser/sparser.h#L152 "Query creation") ⇒ [sparser_calibrate](https://github.com/stanford-futuredata/sparser/blob/70b2084a009ad235fe4e48c540425bd26edf0def/sparser/sparser.h#L434)
I would like to point out that identifiers like “[`_BITMAP_H_`](https://github.com/stanford-futuredata/sparser/blob/70b2084a009ad235fe4e48c540425bd26edf0def/sparser/bitmap.h#L8 "Update candidate")” and “[`_SPARSER_H_`](https://github.com/stanford-futuredata/sparser/blob/70b2084a009ad235fe4e48c540425bd26edf0def/sparser/sparser.h#L23 "Another update candidate")” [do eventually not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28IncludeGuard%29 "Do not use identifiers which are reserved for the...
:eyes: Some Qt objects are created without specifying a corresponding pointer for the parameter “parent”. Examples: * BackUp constructor https://github.com/CSMathematics/DataTex/blob/99fda6b887907f2e8e6b8f2425b09b0c7df1ccec/datatex/backup.cpp#L63-L65 * DataTables::LoadFields https://github.com/CSMathematics/DataTex/blob/a6eff0873df20c42df2ff33eb7f0554f53e625a0/datatex/datatables.cpp#L278-L283 * InfoPage constructor https://github.com/CSMathematics/DataTex/blob/a6eff0873df20c42df2ff33eb7f0554f53e625a0/datatex/basefolder.cpp#L75-L93 * LatexTextBrowser constructor...
Would you like to wrap any pointers with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [AddDatabaseField](https://github.com/CSMathematics/DataTex/blob/99fda6b887907f2e8e6b8f2425b09b0c7df1ccec/datatex/adddatabasefield.cpp#L18) - [InfoPage](https://github.com/CSMathematics/DataTex/blob/a6eff0873df20c42df2ff33eb7f0554f53e625a0/datatex/basefolder.cpp#L75) - [NotesDocuments](https://github.com/CSMathematics/DataTex/blob/0181a85ca991167a16885742507c3416ffe962d0/datatex/notesdocuments.cpp#L16)
[An extra null pointer check is not needed](http://pubs.opengroup.org/onlinepubs/9699919799/functions/free.html) in functions like the following. - [est_destroy](https://github.com/cisco/libest/blob/7ae9b955fa3ee826b5fd969199803419f93de9e2/src/est/est.c#L652) - [process_new_connection](https://github.com/cisco/libest/blob/7b741d404146422156d0a632ccfc0df828858cd9/src/est/est_server_http.c#L1454) Would you like to apply the following [semantic patch](http://coccinelle.lip6.fr/) to find more update...
Would you like to add the configuration script "[AX_PTHREAD](http://www.gnu.org/software/autoconf-archive/ax_pthread.html)" to [your build specification](https://github.com/cisco/libest/blob/8210a1f48971c63fd4c9d135224e3114562281d1/configure.ac#L52)?
I suggest to reuse a higher level build system than [your current small make file](https://github.com/cisco/thor/blob/f32aef3aeb4648e481e34c0891b5cb64cffcaf46/Makefile#L1) so that powerful checks for software features will become easier. - [CMake](http://cmake.org/) - [Autotools](http://www.gnu.org/software/autoconf/#TOCintroduction)