WPEBackend-fdo icon indicating copy to clipboard operation
WPEBackend-fdo copied to clipboard

reserved identifier violation

Open elfring opened this issue 4 years ago • 3 comments

I would like to point out that identifiers like “__initialize_egl_h__” and “__wpe_fdo_h__do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

elfring avatar Nov 07 '20 09:11 elfring

While this is not a pressing issue, I agree that we should avoid using reserved identifiers with leading underscores where possible and it would be a good cleanup to do at some point.

aperezdc avatar Nov 30 '20 20:11 aperezdc

In the case of headers, it would be even better to replace the guards with #pragma once and avoid the issue of needing identifiers for the guards altogether.

aperezdc avatar Nov 30 '20 20:11 aperezdc

How do you think about to achieve standard compliance?

elfring avatar Nov 30 '20 20:11 elfring