Markus Elfring
Markus Elfring
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [CPUKernel](https://github.com/cyrillefavreau/Sol-R/blob/983cc6953c23dc2b2e129379349b654eded40048/solr/engines/cpu/CPUKernel.cpp#L58 "Destructor for CPUKernel") - [GPUKernel::initBuffers](https://github.com/cyrillefavreau/Sol-R/blob/983cc6953c23dc2b2e129379349b654eded40048/solr/engines/GPUKernel.cpp#L345...
Would you like to add more error handling for return values from functions like the following? - [fseek](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fseek.html) ⇒ [posixfs_open](https://github.com/mntmn/interim/blob/32524f7b0fa5f18292871afd89ee72d7764ec19c/devices/posixfs.c#L13) - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [main](https://github.com/mntmn/interim/blob/95d5c838ec646a0081e349261a2d5b559d1e9046/sledge/sledge.c#L23) - [printf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html) ⇒ [init_compiler](https://github.com/mntmn/interim/blob/d3bdbb459fc00c0744a4dc2cf8b4ff5fc7d0a2cb/sledge/compiler_new.c#L1253)
Would you like to add more error handling for return values from functions like the following? - [lseek](http://pubs.opengroup.org/onlinepubs/9699919799/functions/lseek.html) ⇒ [detect_file_type](https://github.com/tkengo/highway/blob/7245c37ba905f2bdffc765e1266bc87042884edd/src/file.c#L11) - [pthread_create](http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_create.html) ⇒ [process_terminal](https://github.com/tkengo/highway/blob/94c6a6e477079408d565f39c2dc9be521b89cf80/src/highway.c#L24)
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://262.ecma-international.org/12.0/#sec-assignment-operators "Description for assignment operators") accordingly....
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
I would like to point out that identifiers like "[`__OVERFEAT_MODULES_HPP__`](https://github.com/sermanet/OverFeat/blob/3c0473d76edf136728e932b2697b8e52e42c9f0d/src/modules.hpp#L6)" and "[`__OVERFEAT_THTENSOR_HPP__`](https://github.com/sermanet/OverFeat/blob/b89f3a1d9f0972888a7224b5049c8ba89fe22f99/src/THTensor.hpp#L1)" [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL32-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C++ language standard. Would you like to adjust...
I suggest to reuse a higher level build system than your current [small Make file](https://github.com/marckhoury/mars/blob/5606a9ac11dba95f1af0e3ea1f7c07c5c8a296f2/Makefile#L1) so that powerful checks for software features will become easier. - [CMake](http://cmake.org/) - [Autotools](http://www.gnu.org/software/autoconf/#TOCintroduction)
I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing. Would you like to add more error...
The function “[exit](http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html "Terminate a process.")” does not belong to the list of [async-signal-safe functions](https://www.securecoding.cert.org/confluence/display/c/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers "Call only asynchronous-safe functions within signal handlers."). I guess that a different program design will...