Markus Elfring
Markus Elfring
Would you like to [wrap any pointer data members](https://github.com/pitzer/SiftGPU/blob/b46bd5b8cc5cfdc1dc163444b72c705569800b6d/src/SiftGPU/PyramidCL.cpp#L50 "Update candidate: PyramidCL class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [ProgramBagCL](https://github.com/pitzer/SiftGPU/blob/b46bd5b8cc5cfdc1dc163444b72c705569800b6d/src/SiftGPU/ProgramCL.cpp#L137 "Destructor for ProgramBagCL") - [PyramidCU](https://github.com/pitzer/SiftGPU/blob/b46bd5b8cc5cfdc1dc163444b72c705569800b6d/src/SiftGPU/PyramidCU.cpp#L70...
Would you like to [replace any double quotes](https://github.com/OpenNI/OpenNI2/blob/3f7d3a135f18d9f4e8816dcfc7f5deb9612f7d84/Include/OpenNI.h#L24) by [angle brackets around file names for include statements](http://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename)?
I would like to point out that identifiers like "[`_OPENNI_H_`](https://github.com/OpenNI/OpenNI2/blob/3f7d3a135f18d9f4e8816dcfc7f5deb9612f7d84/Include/OpenNI.h#L21)" and "[`_ONI_C_API_H_`](https://github.com/OpenNI/OpenNI2/blob/f5acf357800945b6006f77da781494ac85437a31/Include/OniCAPI.h#L21)" [do not fit](https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C language standard. Would you like to adjust...
I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing. Would you like to add more error...
I suggest to try the search pattern "\
I would like to point out that identifiers like "[`_SQUIRREL_H_`](https://github.com/albertodemichelis/squirrel/blob/0961039dd7d7ada57c8db649ab91ac37157834d4/include/squirrel.h#L22)" and "[`_SQVM_H_`](https://github.com/albertodemichelis/squirrel/blob/7bb5dd4982882479e08acf94b1afa37bea0d7070/squirrel/sqvm.h#L2)" [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C++ language standard. Would you like to adjust...
Would you like to add more error handling for return values from functions like the following? - [pthread_mutex_init](http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_mutex_init.html "Initialize a mutex.") ⇒ [critical_section_v4 constructor](https://github.com/01org/tbb/blob/d31fcc68980efbe912dc8cec4978fbb77fb3cf9f/include/tbb/critical_section.h#L51) - [__itt_mutex_lock](https://github.com/01org/tbb/blob/d31fcc68980efbe912dc8cec4978fbb77fb3cf9f/src/tbb/tools_api/ittnotify_config.h#L281 "Lock a mutex.") ⇒...
[An extra null pointer check is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like in [the destructor for the class “AudioEffectWaveshaper”](https://github.com/PaulStoffregen/Audio/blob/8fb976cf20460a45b413f11171e52dd2bc04fe43/effect_waveshaper.cpp#L28 "Update candidate: Destructor for...
I would like to point out that an identifier like “[`__CSV_PARSER_H__`](https://github.com/psibi/csv-parser/blob/22fd59ee4589d596bb8c9ad8a6d2e2aa47ea5bf5/csv_parser.hpp#L21 "Update candidate")” [does eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to...