Markus Elfring

Remove an unnecessary null pointer check

1

[An extra null pointer check is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") in [the function “utp_destroy”](https://github.com/bittorrent/libutp/blob/31103141c4101bc05bfe4c622cb77d17ff90c0f1/utp_api.cpp#L108 "utp_destroy function").

I would like to point out that identifiers like “[`__UTP_H__`](https://github.com/bittorrent/libutp/blob/365254427e5358a0c390aa5a60df5f449b9c0f00/utp.h#L23 "Update candidate")” and “[`__UTP_TYPES_H__`](https://github.com/bittorrent/libutp/blob/9b43d2ee33cebebc5e03c6a9f44626c918675b9b/utp_types.h#L23 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...

Catch exceptions in main()?

1

I expect that exception handling is usually supported by a C++ program. I wonder why your function "[main](https://github.com/xbpeng/DeepTerrainRL/blob/9bd6688598fe82d1e7189b9256693868bb9d4cdd/Main.cpp#L540)" does not contain [corresponding try and catch instructions](http://stackoverflow.com/questions/368184/does-it-make-sense-to-catch-exceptions-in-the-main) so far. How do...

Catch exceptions in main()?

2

I expect that exception handling is usually supported by a C++ program. I wonder why your function "[main](https://github.com/Allexin/TrackYourTime/blob/fa791617b99c65ecb073540fb19ee1c5a58059d2/TrackYourTime/main.cpp#L35)" does not contain [corresponding try and catch instructions](http://stackoverflow.com/questions/368184/does-it-make-sense-to-catch-exceptions-in-the-main) so far. How do...

reserved identifier violation

1

I would like to point out that identifiers like "[`__mg_master_callback`](https://github.com/laurolins/nanocube/blob/bf040bafa545adb43019088a797a1eeb32f32f89/src/Master.cc#L815)" and "[`__server`](https://github.com/laurolins/nanocube/blob/8c809271836c7ad1fdaafea05f694c8d92a11a0b/src/Server.cc#L108)" [do eventually not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier) to the expected naming convention of the C language standard. Would you like to...

Complete build options for Pthread API

1

Would you like to add the configuration script "[AX_PTHREAD](https://www.gnu.org/software/autoconf-archive/ax_pthread.html)" to [your build specification](https://github.com/laurolins/nanocube/blob/6a48d93d654bda7278372ba75c7da44f1c97d55f/configure.ac#L47)?

Would you like to add more error handling for return values from functions like the following? - [fopen](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html) ⇒ [initializeNcserve](https://github.com/laurolins/nanocube/blob/ae30152cc332c0f447f183f75744e2f95ba86dc9/src/nanocube-daemon.cc#L92) - [fscanf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fscanf.html) ⇒ [memory_used](https://github.com/laurolins/nanocube/blob/80e1b02bed2349d9866d129ff26fdfdeda6c0cf3/src/MemoryUtil.cc#L31)

Would you like to [replace any double quotes](https://github.com/laurolins/nanocube/blob/0389adb54dc054e6f4db4f9c8aeb16041c43446f/src/NanoCube.hh#L32) by [angle brackets around file names for include statements](http://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename)?

[An extra null pointer checks is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null) in [a function like the Node destructor](https://github.com/laurolins/nanocube/blob/ae30152cc332c0f447f183f75744e2f95ba86dc9/src/qtfilter.cc#L17).

Would you like to [wrap any pointer data members](https://github.com/cyrillefavreau/Sol-R/blob/983cc6953c23dc2b2e129379349b654eded40048/apps/scenes/animation/MetaballsScene.cpp#L54 "Update candidate: MetaballsScene class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?