Markus Elfring

reserved identifier violation

2

I would like to point out that identifiers like “[`_ME_MARKET_H_`](https://github.com/viabtc/viabtc_exchange_server/blob/d00c09a2f30601bf146e5bc06643e24914cbde0f/matchengine/me_market.h#L6 "Update candidate")” and “[`_RH_SERVER_H_`](https://github.com/viabtc/viabtc_exchange_server/blob/34c7f75f07567179f6ef436b4d5bb322c1c248fc/readhistory/rh_server.h#L6 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not use identifiers which are reserved for the compiler...

Some parameters (like "[${PROJECT_BINARY_DIR}/avbot.rc](https://github.com/avplayer/avbot/blob/fd8d6a6c93b559347edf61547c5d2c379e35c6fd/CMakeLists.txt#L126)" and "[${SQLITE3_INCLUDE_DIR}](https://github.com/avplayer/avbot/blob/1226cead18d2ab5987c5e9edd5314a0767181fd9/rpc/CMakeLists.txt#L4)") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build...

Improve exception safety with smart pointers

1

Would you like to [wrap any pointer data members](https://github.com/memtt/numaprof/blob/6edaaf2b4cfdd8e8830111305345c352146154e1/src/lib/caches/CpuSimpleFlatCache.cpp#L22 "Update candidate: CpuSimpleFlatCache class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?

Remove an unnecessary null pointer check

1

[An extra null pointer check is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") in [the destructor for the class “PageTableLevel”](https://github.com/memtt/numaprof/blob/f8696a27b7bda13e133965cedfadf1ad64426327/src/lib/core/PageTable.hpp#L213 "Destructor for PageTableLevel").

Completion of error handling

2

Would you like to add more error handling for return values from functions like the following? - [ftell](http://pubs.opengroup.org/onlinepubs/9699919799/functions/ftell.html) ⇒ [readTagLineRaw](https://github.com/universal-ctags/ctags/blob/cb0939c78a40cc63761e1916b887670037bc8df4/readtags.c#L171) - [printf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/printf.html) ⇒ [printField](https://github.com/universal-ctags/ctags/blob/b2895073e048078dae905213d873fd5f72ceecf6/main/field.c#L70)

Completion of error handling

2

Would you like to add more error handling for return values from functions like the following? * [fprintf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html "Print formatted output") ⇒ [_MIR_dump_code](https://github.com/vnmakarov/mir/blob/28265ecc24a70c40c2005e53d164d5060664a94c/mir.c#L6154) * [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [mkmatrix](https://github.com/vnmakarov/mir/blob/5dbe37c920c92ef0975d49aafe0e183f26018e42/c-benchmarks/matrix.c#L14)

Reconsider usage of an #include directive

2

How do you think about to [delete the preprocessor directive “`#include `” from your header file](https://github.com/lipnitsk/libcue/blob/7176a1faccecbfe2d4cca2f776177439ca49cad2/libcue.h#L9 "Update candidate")? :thinking: :thought_balloon: Should it be used in a source file instead?

Delete unnecessary checks before some function calls

2

- [The function “free”](https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first "Free a null pointer anyway or check first?") is documented in the way that no action shall occur for a passed null pointer. Redundant safety checks...

:eyes: I find the following statements suspicious because the initialisation with zeros is not needed for the mentioned memory areas. * [`new_cdtext = (Cdtext *) calloc (sizeof (cdtext) / sizeof...

:eyes: [The implementations of the functions “cue_parse_file” and “cue_parse_string”](https://github.com/lipnitsk/libcue/blob/7176a1faccecbfe2d4cca2f776177439ca49cad2/cue_parser.y#L340-L384 "Development status") contain a bit of common code. How do you think about to [extract it to another function](https://refactoring.com/catalog/extractFunction.html "Description for...