Markus Elfring
Markus Elfring
Would you like to [replace any double quotes](https://github.com/Kolkir/cpptask/blob/060826b6614f5dcc86eb8bd2c0d2426a7df2e541/include/cpptask/cpptask.h#L33) by [angle brackets around file names for include statements](http://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename)?
I would like to point out that identifiers like "[`_CPP_TASK_CACHE_LINE_SIZE_`](https://github.com/Kolkir/cpptask/blob/060826b6614f5dcc86eb8bd2c0d2426a7df2e541/include/cpptask/cpptask.h#L31)" and "[`_CPP_TASK_THREADPOOL_H_`](https://github.com/Kolkir/cpptask/blob/060826b6614f5dcc86eb8bd2c0d2426a7df2e541/include/cpptask/threadpool.h#L28)" [do eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier) to the expected naming convention of the C++ language standard. Would you like to...
I would like to point out that an identifier like “[`__CRFSUITE_API_HPP__`](https://github.com/chokkan/crfsuite/blob/8748185490aa8164d4fba8706ba8fbbd07db545e/include/crfsuite_api.hpp#L31 "Update candidate")” [does not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the...
Would you like to wrap any pointer data members with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [CDObject](https://github.com/oskardolch/SteamCAD/blob/694c8bacd9b48e382546e3cfcfb9981b622e1960/Source/DDrawTypes.cpp#L35) - [CMainWnd](https://github.com/oskardolch/SteamCAD/blob/6084da03d54cd3b80f3158176088316819c401ef/Win32/MainWnd.cpp#L83)
I would like to point out that an identifier like “[`_DPARSER_HPP_`](https://github.com/oskardolch/SteamCAD/blob/45613afa77ae848981b82db60e905414500b5190/Source/DParser.hpp#L1 "Update candidate")” [does not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the...
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null) like the following. - [DynamicList](https://github.com/warriorguo/zertcore5/blob/3b47a37133857f13fb76c963c17922a02d092522/zertco5/utils/updatelist/DynamicList.h#L38) - [UpdateList](https://github.com/warriorguo/zertcore5/blob/3b47a37133857f13fb76c963c17922a02d092522/zertco5/utils/updatelist/UpdateList.h#L62)
I am looking for programming interfaces which support to copy trees while preserving referential integrity. Further data processing can be performed with such copies.
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....
[An extra null pointer check is not needed in functions](http://dietmar-kuehl.de/mirror/c++-faq/freestore-mgmt.html#faq-16.8) like the following. - [LDBCommand](https://github.com/stellar/stellard/blob/86549bc32b24a96a5bcf95d1d855859484f6d3b6/src/ripple/rocksdb/rocksdb/util/ldb_cmd.h#L78) - [ReplayIteratorImpl::cleanup](https://github.com/stellar/stellard/blob/86549bc32b24a96a5bcf95d1d855859484f6d3b6/src/hyperleveldb/db/replay_iterator.cc#L97) - [Table::Open](https://github.com/stellar/stellard/blob/86549bc32b24a96a5bcf95d1d855859484f6d3b6/src/leveldb/table/table.cc#L38)
I have observed that software components which are provided by ISO files can behave differently according to the configuration aspect when selected systems were booted by an UEFI environment (or...