vvenc icon indicating copy to clipboard operation
vvenc copied to clipboard

Published 20 hours ago • verified publisher icon fraunhoferhhi

Remove unnecessary null pointer checks

Open elfring opened this issue 2 years ago • 6 comments

An extra null pointer check is not needed in functions like the following.

elfring avatar Mar 01 '23 20:03 elfring

It's also not wrong tho. We might change it eventually. Feel free to make a PR for it.

adamjw24 avatar Mar 06 '23 08:03 adamjw24

:thought_balloon: Would you become interested to use a development tool like “clang-tidy” for corresponding source code adjustments?

elfring avatar Mar 06 '23 09:03 elfring

I've been playing around with that idea but nobody knows this tool around here. We would need external help to set it up.

On similar note, it would also be nice to have a more strict enforcement of style guides.

adamjw24 avatar Mar 06 '23 10:03 adamjw24

:thought_balloon: Would you like to take the C++ guideline “R.11: Avoid calling new and delete explicitly” better into account?

elfring avatar Mar 06 '23 10:03 elfring

It seems I'm talking to a bot. Locking this conversation. If someone is interested to help, please do. If its necessary to continue this discussion, please open a new issue.

adamjw24 avatar Mar 06 '23 11:03 adamjw24

Unlocking. Apparently I was wrong. Please stick to the discussion until opening a new topic.

adamjw24 avatar Mar 06 '23 12:03 adamjw24