Markus Elfring
Markus Elfring
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
I would appreciate further clarification around information like the following. * https://github.com/google/styleguide/blob/5651966e0275572a9956199418d89c9ccc7b2b1a/cppguide.html#L969 … Smart pointers (unique_ptr, shared_ptr): smart pointers execute cleanup during destruction and are therefore forbidden. … * https://github.com/google/styleguide/blob/5651966e0275572a9956199418d89c9ccc7b2b1a/cppguide.html#L2102...
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [firebird_standard_use_type_backend::clean_up](https://github.com/SOCI/soci/blob/b36f437bc7192637f64a896ce7b8761b1dabf0fc/src/backends/firebird/standard-use-type.cpp#L188 "firebird_standard_use_type_backend::clean_up function") - [odbc_vector_into_type_backend::clean_up](https://github.com/SOCI/soci/blob/424d25843821d5ade0c90946ee5f9f98d896913d/src/backends/odbc/vector-into-type.cpp#L486 "odbc_vector_into_type_backend::clean_up...
I would like to point out that an identifier like “[`_OPENVAS_H`](https://github.com/greenbone/openvas/blob/d12adfde604fbfcb5cafacd31cb7a1d79069f857/src/openvas.h#L25 "Update candidate")” [does not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28IncludeGuard%29 "Do not use identifiers which are reserved for the compiler implementation.") to the expected...
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
Some parameters (like "[${POSTGRESQL_INCLUDE_DIR}](https://github.com/pgRouting/pgrouting/blob/e673b95a0d098be59ebb7f52b6ec3e1ab7782516/CMakeLists.txt#L203)" and "[${DOC_TARGET}](https://github.com/pgRouting/pgrouting/blob/3cfbc56a5b05c64904242e8fa9c7965f3a51ccee/doc/CMakeLists.txt#L95)") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build...
I would like to point out that identifiers like “[`__PPMENU_H`](https://github.com/papyrussolution/OpenPapyrus/blob/fb3a8fb9716a8413454abbb105c080c59c2595e5/Src/Include/PPMENU.H#L6 "Update candidate")” and “[`__TV_H`](https://github.com/papyrussolution/OpenPapyrus/blob/a510a183d903b613d1951ad84fdecc8dd2db071c/Src/Include/tv.h#L4 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the...
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. * [DOS_File](https://github.com/papyrussolution/OpenPapyrus/blob/bbd0b6e20cd81eec7f52cb91d7780a2908e4d0be/Src/OSF/vDOS/include/dos_system.h#L32 "Destructor for DOS_File") * [LazyDupCursor](https://github.com/papyrussolution/OpenPapyrus/blob/b3614950a76445c32da5812596e51be9dafb4365/Src/OSF/BDB-6232/lang/cxx/stl/dbstl_dbc.h#L100...