soci icon indicating copy to clipboard operation
soci copied to clipboard

Remove unnecessary null pointer checks

Open elfring opened this issue 7 years ago • 3 comments

An extra null pointer check is not needed in functions like the following.

elfring avatar Aug 06 '18 13:08 elfring

It's harmless, but feel free to submit a pull request.

mloskot avatar Aug 06 '18 13:08 mloskot

How do you think about to use smart pointers at affected source code places instead?

elfring avatar Aug 06 '18 14:08 elfring

Please, do not apply any C++ modernisations that would require C++11 or later.

If you wish to contribute, just remove the redundant if check, simple as that and please resist any large scale modernisations.

mloskot avatar Aug 06 '18 14:08 mloskot