Markus Elfring
Markus Elfring
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
Would you like to [wrap any pointer data members](https://github.com/projectchrono/chrono/blob/930606bde27a1c25bec371f7b73fb88f112d47c6/src/chrono/solver/ChVariablesGeneric.cpp#L22 "Update candidate: ChVariablesGeneric class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?
[Extra null pointer checks are not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. * [ChConstraintThreeGeneric](https://github.com/projectchrono/chrono/blob/54807ac75a4920c7b87a08725370b82a4cc5c960/src/chrono/solver/ChConstraintThreeGeneric.cpp#L45 "Destructor for ChConstraintThreeGeneric") * [ChGaussPoint](https://github.com/projectchrono/chrono/blob/b22922cadcc0bc1271290103cb1a4448df5dd74e/src/chrono_fea/ChGaussPoint.cpp#L33 "Destructor...
Would you like to [replace any double quotes](https://github.com/projectchrono/chrono/blob/930606bde27a1c25bec371f7b73fb88f112d47c6/src/chrono/physics/ChLinksAll.h#L20 "Check inclusion style") by [angle brackets around file names for include statements](https://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename "What is the difference between #include and #include “filename”?")?
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
[Augmented assignment statements became available with Python 2](https://docs.python.org/3/whatsnew/2.0.html#augmented-assignment "Augmented assignments"). :thought_balloon: Thus I suggest to improve four source code places accordingly.
Would you like to add more error handling for return values from functions like the following? - [fclose](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fclose.html) ⇒ [MemoryStatus constructor](https://github.com/griddb/griddb_nosql/blob/33d41b47029f9469d3d5c0ac2222569a4f334a00/utility/util/system.cpp#L165) - [pthread_cond_broadcast](http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_cond_broadcast.html) ⇒ [Condition::broadcast](https://github.com/griddb/griddb_nosql/blob/33d41b47029f9469d3d5c0ac2222569a4f334a00/utility/util/thread.cpp#L245)
Would you like to add the configuration script "[AX_PTHREAD](https://www.gnu.org/software/autoconf-archive/ax_pthread.html)" to [your build specification](https://github.com/griddb/griddb_nosql/blob/b689db29dadfc59bd32112586021cca9bb798cb0/configure.ac#L8)?