Markus Elfring
Markus Elfring
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://262.ecma-international.org/12.0/#sec-assignment-operators "Description for assignment operators") accordingly....
Would you like to add more error handling for return values from functions like the following? - [fprintf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html "Print formatted output") ⇒ [usage](https://github.com/p-gen/smenu/blob/55d3516e79de3866d49644f04bab18f945181fca/smenu.c#L516) - [strdup](http://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html "Duplicate a string") ⇒ [parse_sed_like_string](https://github.com/p-gen/smenu/blob/d1cd68bee7e745f10c3d35238cde418cf3151314/smenu.c#L2016)
Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [list_windows](https://github.com/sdhand/x11fs/blob/f29cfe7ff5fe8283caa452bee2653b0c7f093802/src/win_xcb.c#L51) - [strdup](http://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html) ⇒ [x11fs_readdir](https://github.com/sdhand/x11fs/blob/8e0c1a28d7d9a68bf8f54a9059c36d13ca541d56/src/x11fs.c#L122)
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....
[A build configuration check](https://github.com/ggreer/the_silver_searcher/blob/1a5e259b259130b50607174fc9f9508dc1f2941c/configure.ac#L19 "Checking for PCRE support") refers still to the programming interface “PCRE”. :crystal_ball: How are the chances to [support the API “PCRE2”](https://pcre.org/ "Software evolution around Perl-compatible regular...
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
The function "[exit](http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html)" does not belong to the list of [async-signal-safe functions](https://www.securecoding.cert.org/confluence/display/c/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers). I guess that a different program design will be needed for your function "[ya_sighandler](https://github.com/geommer/yabar/blob/5fcc0114354feebe90a7afe81d68791d8dad8f5c/src/ya_exec.c#L100)".
Would you like to add more error handling for return values from functions like the following? - [calloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/calloc.html) ⇒ [ya_setup_block](https://github.com/geommer/yabar/blob/5fcc0114354feebe90a7afe81d68791d8dad8f5c/src/ya_exec.c#L234) - [signal](http://pubs.opengroup.org/onlinepubs/9699919799/functions/signal.html) ⇒ [ya_init](https://github.com/geommer/yabar/blob/5fcc0114354feebe90a7afe81d68791d8dad8f5c/src/ya_exec.c#L122)
[An extra null pointer check is not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [clone_ptr](https://github.com/jpbarrette/curlpp/blob/fd8f1d9564a0aa256ebca9347c769ec2e9979d9e/include/utilspp/clone_ptr.hpp#L55 "Destructor for clone_ptr") - [CountingBody](https://github.com/jpbarrette/curlpp/blob/9f35688e806436067380220c35f2272a5321d224/include/utilspp/SmartPtr.hpp#L95...
The function "[exit](http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html)" does not belong to the list of [async-signal-safe functions](https://www.securecoding.cert.org/confluence/display/c/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers). I guess that a different program design will be needed for your function "[terminate](https://github.com/simsong/tcpflow/blob/5eb5bd1dc8a918f6dee57c3b68558d51d8acf9b6/src/tcpflow.cpp#L199)".