Markus Elfring

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

Complete quoting for parameters of some CMake commands

2

Some parameters (like “[${CMAKE_CURRENT_BINARY_DIR}/shd-config.h](https://github.com/shadow/shadow/blob/e15d3ccf6a8ceeb4be5ef870a3dce202295ffa4a/CMakeLists.txt#L128)”) are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if...

Remove unnecessary null pointer checks

4

[An extra null pointer check is not needed in functions](https://developer.gnome.org/glib/stable/glib-Memory-Allocation.html#g-free "Do I need to check for null before g_free(p)?") like the following. - [bytechunk_free](https://github.com/shadow/shadow/blob/9fce6e321e05a15db85ed20a546430fa21677efb/src/main/utility/shd-byte-queue.c#L43 "bytechunk_free function") - [_logrecord_free](https://github.com/shadow/shadow/blob/9fce6e321e05a15db85ed20a546430fa21677efb/src/main/core/logger/shd-log-record.c#L45 "_logrecord_free function")...

reserved identifier violation

5

I would like to point out that identifiers like “[`_Slave`](https://github.com/shadow/shadow/blob/5e490156e5fbb8a4b3fad95606740528f13cb05e/src/main/core/shd-slave.h#L25 "Update candidate")” and “[`_WorkerRunData`](https://github.com/shadow/shadow/blob/069e715a827d51a3251ab082e28beae5b36983ff/src/main/core/shd-worker.h#L12 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not declare an identifier which is reserved for the...

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://docs.oracle.com/javase/specs/jls/se17/html/jls-15.html#jls-15.26 "Description for assignment operators") accordingly....

Checking correctness for multi-target rules

17

[Multiple targets](https://www.gnu.org/software/make/manual/html_node/Multiple-Targets.html "Multiple targets in a rule") can be specified in a single make rule. While they are written only once at such a place, the make software usually expands...

Increase the usage of augmented assignment statements

13

I suggest to [use an augmented assignment statement](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") also at the following place in the function “getData” of the script “guider.py”. ```diff # composite packets # -...

Export tracing records in rows instead of multi-line structures

49

Some tracing data are offered as data structures which are distributed over multiple lines. Example: [Call and return information](https://github.com/iipeace/guider/issues/259#issuecomment-927969512 "Description for a data format") according to function executions I suggest...

Reconsider “import gc”

1

The software development environment “Eric 21.1” pointed out that the imported module “gc” would not be used so far. How do you think about to delete the corresponding statement? :thinking:

Support the configuration of a shell environment before tracing a passed command

10

The tool “guider” supports tracing (or profiling) for passed commands. These commands are directly executed so far. But this execution configuration should be adjusted for some use cases. We are...