OpenPapyrus icon indicating copy to clipboard operation
OpenPapyrus copied to clipboard

reserved identifier violation

Open elfring opened this issue 6 years ago • 5 comments

I would like to point out that identifiers like “__PPMENU_H” and “__TV_Hdo not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

elfring avatar Aug 22 '18 10:08 elfring

This pratice has been used by as since 90th last century. It's hard to change this tradition :)

papyrussolution avatar Aug 22 '18 11:08 papyrussolution

How do you think about to avoid that this software depends on undefined behaviour?

elfring avatar Aug 22 '18 11:08 elfring

We use a double-underscore. I don't think it can cause some problems (i consider such a propability as very low). Nevertheless, i gratitude you, because i didn't know about that considaration (depends on undefined behaviour).

papyrussolution avatar Aug 22 '18 13:08 papyrussolution

@elfring Can you please answer this https://github.com/papyrussolution/OpenPapyrus/issues/11

ugintl avatar Aug 05 '22 19:08 ugintl