Markus Elfring
Markus Elfring
I suggest to reuse a higher level build system than [your current small make file](https://github.com/jonsneyers/FLIF/blob/495c6b7770c97c43d88a3a1da3058c9991cdc9fb/Makefile#L1) so that powerful checks for software features will become easier. - [CMake](http://cmake.org/) - [Autotools](http://www.gnu.org/software/autoconf/#TOCintroduction)
[An extra null pointer check is not needed in a function](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like [the destructor for the class “QuantEncoding”](https://github.com/libjxl/libjxl/blob/f7b4c2cb35c70d81f93e04be05d8082d0ac56b58/lib/jxl/quant_weights.h#L238 "Update candidate").
The function “[exit](http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html "Terminate a process.")” does not belong to the list of [async-signal-safe functions](https://www.securecoding.cert.org/confluence/display/c/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers "Call only asynchronous-safe functions within signal handlers."). I guess that a different program design will...
Would you like to add more error handling for return values from functions like the following? - [fopen](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fopen.html "Open a stream") ⇒ [blacklist_load](https://github.com/dvorka/hstr/blob/b7d89c02b839b0c164fc24b665abea9a3e731fa7/src/hstr_blacklist.c#L54) - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [favorites_init](https://github.com/dvorka/hstr/blob/b7d89c02b839b0c164fc24b665abea9a3e731fa7/src/hstr_favorites.c#L23) -...
Would you like to add more error handling for return values from functions like the following? - [fputs](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fputs.html "Put a string on a stream") ⇒ [file_emit](https://github.com/openlink/virtuoso-opensource/blob/5c50483b18a2bdc89b3444452a6116aee6c63680/libsrc/util/logmsg.c#L575) - [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation")...
I have seen that [no loop is used around a call](https://github.com/openlink/virtuoso-opensource/blob/5c50483b18a2bdc89b3444452a6116aee6c63680/libsrc/Thread/sched_pthread.c#L1549 "Update candidate: gprof_pthread_create()") of the function “[pthread_cond_wait](http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_cond_wait.html "Wait on a condition")”. Would you like to reuse anything from my...
I would like to point out that identifiers like “[`__DLF_H__`](https://github.com/openlink/virtuoso-opensource/blob/5c50483b18a2bdc89b3444452a6116aee6c63680/libsrc/plugin/dlf.h#L28 "Update candidate")” and “[`_IID`](https://github.com/openlink/virtuoso-opensource/blob/5c50483b18a2bdc89b3444452a6116aee6c63680/binsrc/virtuoso_sink/SmtpEvent_i.c#L71 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier "Do not use identifiers which are reserved for the compiler...
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://perldoc.perl.org/perlop#Assignment-Operators "Description for assignment operators") accordingly....
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....