Bence Magyar

Results 97 issues of Bence Magyar

## Background It turns out, some of our controllers forgot to reset their buffers when deactivating/reactivating! We've implemented a quick fix for it in https://github.com/ros-controls/ros2_controllers/pull/246 (see the `Files Changed` tab)...

help wanted
good first issue

Our integration tests currently have a recurring pattern where the robot hardware read/update/write steps are repeated a couple of times in a loop until a condition is met. An occurence...

good first issue

# Problem: std_msgs/Float64MultiArray is deprecated. ``` # This was originally provided as an example message. # It is deprecated as of Foxy # It is recommended to create your own...

Why are those tests commented out? _Originally posted by @destogl in https://github.com/ros-controls/ros2_controllers/pull/112#discussion_r531689839_

Load controller & verify command forwarding. I think there's value in it from an integration test perspective. _Originally posted by @bmagyar in https://github.com/ros-controls/ros2_controllers/pull/92#discussion_r499214503_

We could discuss the logic here. Maybe there is another way to do this, without so much looping... (but let's leave it for the future) _Originally posted by @destogl in...

* [ ] create a .clang-format and apply it to the whole codebase * [ ] create a .clang-tidy and apply it the whole codebase * [ ] set up...

With the advent of this new feature our lack of documentation & examples increases even more in contrast to the features we have. I would like to ask @toliver is...

Hello folks, I gave a shot to pull request templates this morning and I think it would help to have them on the ros-controls repos. Github blog entry: https://github.com/blog/2111-issue-and-pull-request-templates My...

Rebase & quick fixup of https://github.com/ros-controls/ros_controllers/pull/149