ros_control icon indicating copy to clipboard operation
ros_control copied to clipboard

CombinedRobotHW documentation

Open bmagyar opened this issue 8 years ago • 6 comments

With the advent of this new feature our lack of documentation & examples increases even more in contrast to the features we have.

I would like to ask @toliver is you could provide some very minimal but working examples (can be taken from the tests for instance) with a little bit of discussion, perhaps a figure showing how the structure of a RobotHW and example configurations to set up. The information in #231 can be a good starting point. Can you do this please?

It could go to the ROS wiki and it would be nice to have it in the repo as a .md too.

bmagyar avatar May 24 '16 10:05 bmagyar

Just going to leave this here, since it's probably the best available documentation at the moment :)

https://vimeo.com/187696094

paulbovbel avatar Oct 27 '16 00:10 paulbovbel

Thanks Paul, I'll update the wiki with this and the older talk of Adolfo too!

On 27 October 2016 at 01:39, Paul Bovbel [email protected] wrote:

Just going to leave this here, since it's probably the best available documentation at the moment :)

https://vimeo.com/187696094

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ros-controls/ros_control/issues/237#issuecomment-256516229, or mute the thread https://github.com/notifications/unsubscribe-auth/ADXH4VCVaLZQYy1lNPnNkn2YgEvTo6Bmks5q3_KygaJpZM4IlW6c .

bmagyar avatar Oct 27 '16 15:10 bmagyar

Sorry for opening this again, but is there a chance that someone has written a complete example of using combinedhw?

My main question is what relation has combinedhw with some robothw? Does I have to start first robothw package then combinedhw or does combinedhw start robothw itseld? Where I have then to put the config of robothw? Why I have than to use pluginlib for exporting my robothw?

There are plenty questions open but no complete examples. I want just a simple scenario. Some 2 dump robothw with some hardcoded states and command, but where I can clearly see that my both robothws are now one through combinedrobothw

If I have two robothw packages from two devices or vendors does I have to take it apart or I can use it as is?

For some reason the combined_robot_hw_tests does not build the necessary nodes for running the test.

Thank you!

ptiza-v-nebe avatar Oct 01 '18 20:10 ptiza-v-nebe

I have managed now to understand how things works. Here some first trying to make some tutorial for the whole picture of how implementing CombinedRobotHW. https://github.com/ros-controls/ros_control/wiki/Writing-CombinedRobotHW

ptiza-v-nebe avatar Oct 09 '18 09:10 ptiza-v-nebe

@ptiza-v-nebe Thanks for making the effort of writing documentation for this package (something that I didn't get around to do yet).

Just for completion, the combined_robot_hw_tests package does in fact contain a running example with 4 different RobotHW instances being loaded by the CombinedRobotHW instance that runs in the node called dummy_app (see here). Of course that is not a replacement for good documentation :)

toliver avatar Oct 25 '18 17:10 toliver

Ahh yes the tests :) Problem on them was I didn't got them to run. The other side is they are too cryptically for someone who is entering ros-control and maybe ros overall. My wish was to have something globally that I can just download and start, then to build on and how you said good docu :)) Would it better to move this one to wiki.ros.org? Maybe you can mention some more details on functionality of combohw and I can better this little docu?

ptiza-v-nebe avatar Oct 27 '18 09:10 ptiza-v-nebe