Bence Magyar
Bence Magyar
#71 piece by piece
Review the code and feature list of diff_drive_controller from ROS1 and write up a comparison with the current version in ROS2, don't forget about testing either. Please make sure to...
Could we also change this macro to `RCLCPP_ERROR` instead of stream? There is no value in it, but it's confusing to read. I know I am asking for something out...
these callback aren't named properly anymore. the follow-up of accepting the goal is meant to happen in the 3rd bound function which is confusingly named `feedback_setup_callback`. we should rename them...
Investigate how to refactor these cascading `if`s so that it is easier to read which conditions together lead to a failure. This section of the code looks like a table...
This set of cascading `if`-s should be refactored into something more readable. I suggest 2 things: * make the selection of choosing the command somehow more explicit with different variable...
realtime_tools was not ported really well which led to little adoption of it in the new controllers. Once we have https://github.com/ros-controls/realtime_tools/issues/81 completed, the controllers should be reviewed & refactored to...
Review the code and feature list of joint_trajectory_controller from ROS1 and write up a comparison with the current version in ROS2, don't forget about testing either. https://github.com/ros-controls/ros_controllers/tree/noetic-devel/joint_trajectory_controller https://wiki.ros.org/joint_trajectory_controller The ticket...
It causes sporadic failures on the CI ``` Function 'run_target_test' returned with code '0' after 0 min 27 sec build/joint_trajectory_controller/Testing/20201223-1353/Test.xml: 10 tests, 0 errors, 1 failure, 0 skipped - test_trajectory_actions...