Andrew Scott

I ask the team to patch in the change, run the application, and check if the scrolling is broken. The issue is that when scrolling is performed, it continues infinitely....

This PR was merged into the repository by commit 9e847fc60d4eef47e665e789ccd2d4f0b4bb94ea. The changes were merged into the following branches: main, 19.1.x

[global](https://test.corp.google.com/ui#id=OCL:301607837:BASE:301831157:1584635402186:f11b8230) presubmit ran and no failures as a result of this PR so it should be good to go once CI is green.

So the upgrade module appears to depend on ZoneJS: https://github.com/angular/angular/blob/abcb865474c4224ac47eed25100ec8f632fd7966/packages/upgrade/static/src/upgrade_module.ts#L298 https://github.com/angular/angular/blob/abcb865474c4224ac47eed25100ec8f632fd7966/packages/upgrade/src/dynamic/src/upgrade_adapter.ts#L655 I can look into whether it's possible to change this though it likely carries some amount of risk since...

Removing the language service tag. The Angular language service does not provide any autocomplete information at this location. It only provides Angular-specific information, mostly in templates, but sometimes in some...

@passee Do you mean that enabling the Angular language service breaks this? That is, if you disable the Angular language service, it works?

Cc @crisbeto and @devversion again. As mentioned in the original issue, this doesn’t seem like a problem with Angular but rather VSCode or TypeScript.

There's a lot of duplication in the steps for "Let cancel be the following steps given reason:" and "To abort the ongoing navigation given a Navigation navigation and an optional...

Presumably this would generally be covered by signal forms. Effects around the value would always execute an initial time and read the first value, as would computed or other signal...

@yjaaidi can you please update the commit to be a `feat` rather than `refactor`?