Andrew Scott comments

Results 264 comments of


                                            Andrew Scott

Two levels of empty path children seems to break static redirects

Just looking at what’s written, since there’s no runnable reproduction, the two are not equivalent in their nesting. The example without loadChildren should be: ``` export const routes: Routes =...

`@angular/builder:unit-test` doesn't support `fakeAsync`

`vi.useFakeTimers` can be used and you should stick to the async variants `vi.tickAsync`/`vi.runAllTimersAsync`/etc to allow the microtask queue to drain between each task.

Router scrolling does not work properly when dealing with content that is not immediately visible

Confirmed in v9 as well: https://stackblitz.com/edit/angular-7fpprl-ft1ezk?file=main.ts, https://angular-7fpprl-ft1ezk.stackblitz.io/#qwe

Router scrolling does not work properly when dealing with content that is not immediately visible

> Is it possible for the Angular team to provide a status for this issue There is no update on this issue, nor is any work planned for it at...

feat(router): support for object in queryParams

[TGP](https://fusion2.corp.google.com/presubmit/720242782/OCL:720242782:BASE:720180594:1738024322903:600ea433/targets) shows 21 failures, many of which are due to 0-1 query. There are a handful of others that will need some more digging. The results here sound quite similar...

feat(router): support for object in queryParams

Closing, per https://github.com/angular/angular/pull/58580#issuecomment-2622389064

Router behavior when route reuse strategy is being used with nested routes

You _really_ cannot reuse the `ActivatedRoute` instance that matched to the route with `{path: 'Bar', data: {path: '/Foo/Bar - root'}, children: [...]}` for the route `{path: '', pathMatch: "full", component:...

fix(core): handle view destruction during effect execution

I think @alxhub should probably review this

scrollPositionRestoration should not scroll to top when hydrating SSR application

Yea, that's definitely an issue. There's currently no way to control whether scroll happens on an individual navigation but that should change soon (https://github.com/angular/angular/pull/64417). Once that's in place, perhaps the...

Syntax error with Angular Language Service VSCode extension

Please provide a reproduction. The given steps alone would not result in the error.