Andrew Scott

Results 264 comments of Andrew Scott

> @atscott do you want me to squash the commits or keep them separated? What you have is fine

By the way, these problems generally go away if the fake timer library has a way to enable automatically advancing time (https://github.com/jasmine/jasmine/pull/2042, https://github.com/jestjs/jest/pull/15300)

I’m going to close this as a mock clock problem (issue outside Angular). Jasmine now has an autoTick feature that works quite nicely for this. jest and vitest could have...

TGP=https://fusion2.corp.google.com/presubmit/839808026/OCL:839808026:BASE:840282024:1764869895416:7dd764a4/targets

TGP=https://fusion2.corp.google.com/presubmit/838847171/OCL:838847171:BASE:839322087:1764739516284:b70560b6/targets

I'm trying to understand the actual issues being encountered here but there aren't really any clear steps to reproduce. Would it be enough to allow configuring which characters are allowed...

This does seem like its due to the `Occurrences Highlight` feature. The language service already switches the language inside the template string to `html` and isn't actively providing a highlight...

@JeanMeche That's not quite the issue being described. I haven't looked at the problem when Zone.js is on the page, but it doesn't surprise me entirely (could be related to...

Great, thanks for confirming without a doubt that it’s https://github.com/angular/angular/issues/51357#issuecomment-2555564572 I think then that the ZoneJs portion of this bug already has a tracking issue (and finally I know why...

@sgravrock bumping the version in either a patch or getting another karma-jasmine release out is something we’re open to. The concern would be that’s it’s effectively an untested version upgrade...