Andrew Scott

This seems like it would be a pretty easy fix as long as it's not a breaking change. This line could throw the error instead of simply returning: https://github.com/angular/angular/blob/0268b72d2c4690b554408aa64e9ae2fc42fa490c/packages/core/src/render3/instructions/shared.ts#L384 It...

The Ivy implementation of the querying assumes that if an element was created by Angular (excluding `Renderer2`), all children were created in the same ecosystem. Only when the parent was...

The current activated route is the current activated route. This is as @JoostK has described. Closing as working as intended. FYI - you can get what you're looking for with...

@ArielGueta Yes. It's called twice because there are two stages at the beginning of the routing pipeline that need to call it. One which determines the final URL for the...

The issue here is that the directive isn't even getting matched. I think the `attr.` selector really should never match (it does in VE/pre-Ivy), but I also think it was...

Closing as resolved by the feature which allows guards as plain functions (https://github.com/angular/angular/commit/0abb67af59a92a2b29082a259aa9f4ea3fbaab7d). You can now accomplish this configurability by having a factory function that accepts configuration and returns a...

@brandonroberts Thanks for the feedback! > Is it possible to have an object-based config to enable features and provide the same tree-shaking? This makes configuring the router much more verbose...

This PR was merged into the repository by commit 0abb67af59a92a2b29082a259aa9f4ea3fbaab7d.

This PR was merged into the repository by commit c1ad37d1618141255852d8b52d618af198b90d17.

Closing. There was only 1 failure in TGP as a result of this change due to import ordering. In the test, both `RouterModule` and `RouterTestingModule` were provided. Likely due to...