Andrew Scott

Results 123 comments of Andrew Scott

It doesn't seem like there's been any discussion here about using `canActivate` as your module initializer at the root of the `forChild` module. ``` RouterModule.forChild([ {path: '', canActivate: [MyInitializerGuard], children:...

@johnc-ftl Absolutely good points. Agreed that these are things that cannot be solved in the router. It may still be a good option for many who have commented here but...

> With the new component creation apis, this feature would be easier to implement. This is correct, but more specifically this PR in particular: [feat(core): add ability to set inputs...

Open question for reviewers: When updating the tests in the router package to use the new `provideRouterForTesting` API, I kept using `withXFeature` without putting it in an array. Should we...

[TGP](https://fusion2.corp.google.com/presubmit/tap/462222574/OCL:462222574:BASE:464784234:1659471670383:23733193/targets)

Blocked by https://github.com/angular/angular/pull/46929. Using the current default factory for `PathLocationStrategy` results in the `APP_BASE_HREF` and `` elements being ignored.

All internal tests passed in the [TGP](https://fusion2.corp.google.com/presubmit/tap/464574397/OCL:464574397:BASE:464543952:1659392273198:10643d5/targets). This change is good to go once comments are resolved.

Yes, "starts life" refers to an application that was written in AngularJS and is being upgraded to Angular gradually.

Closing as this has gotten out of date. @JiaLiPassion If this is still something you want to do, please open a new PR.

This is somewhat described in https://angular.io/guide/deployment#the-deploy-url. > The base href can also be used to define the Angular router's default base (see [APP_BASE_HREF](https://angular.io/api/common/APP_BASE_HREF)). Users with more complicated setups may need...