Andrew Scott

Results 60 issues of Andrew Scott

This commit creates and exposes the APIs required to use the Angular Router without importing `RouterModule`. By updating the golden test to use the new API, this change also demonstrates...

comp: router
target: minor

The current Router APIs require guards/resolvers to be present in the DI tree. This is because we want to treat all guards/resolvers equally and some may require dependencies. This requirement...

comp: router
target: minor

The PathLocationStrategy is already provided by default in the factory of LocationStrategy

comp: router
target: patch
action: global presubmit

The `browserUrlTree` is _only_ used to support the `onSameUrlNavigation: 'ignore'` logic. We can achieve this functionality without having this state tracked inside the Router. Instead, we can re-examine what `ignore`...

action: review
area: router
risky
action: global presubmit

Further document the rawUrlTree and how it's used internally in the Router.

action: merge
area: docs
area: router
target: patch

Returning `UrlTree` from a guard was a convenient new feature added to the `Router`. However, it does not have feature-parity with the old `router.navigate(...); return false;` pattern. The most common...

action: review
area: router
target: minor

The `initNavigated` flag is not necessary. The way `enabledBlocking` works is by blocking any navigations from finishing until the application has bootstrapped. The bootstrap is unblocked as soon as we...

area: router
target: patch

This commit extracts the Router's navigation "transitions" to a separate file. The goal here is twofold: - Separate the Router's logic into more manageable chunks. Rather than having to always...

action: merge
area: router
target: patch

The router providers a configurable `onSameUrlNavigation` value that allows developers to configure whether navigations to the same URL as the current one should be processed or ignored. However, this only...

feature
area: router
target: minor
detected: feature

first two commits are part of https://github.com/angular/angular-cli/pull/24170. The two commits specific to this are the default updates, which may be considered a breaking change.

action: cleanup
target: major
detected: feature
detected: deprecation