Andrew Scott

Results 264 comments of Andrew Scott

@mrazauskas happy to continue iterating on the API naming. Would you also be able to help with the CI failures? I’m not sure what’s going on there.

@mrazauskas I've changed the implementation to overload `advanceTimersToNextTimerAsync` in a fixup commit. Let me know what you think of it this way.

I'm all for making this a new option on the `advanceTimers` config. One caveat is that the function new corresponding function for updating this after it's created, `jest.setAdvanceTimers(...)`, would not...

I've updated the implementation to extend the existing `advanceTimers` in the `FakeTimersConfig` and add a new `setAdvanceTimers` option with a warning about not being able to use it with the...

I added some more tests to ensure the API works well with calls to the async tick methods. In doing this, I've started to feel that the auto tick machinery...

Yea, I'll convert this PR to draft until the story with implementing it in sinon becomes more clear since it'll still need to be exposed in the jest APIs and...

> just to check ... You are aware of await clock.runAllAsync() and await clock.runToLastAsync(), right? They often solve the issues of needing intimate knowledge about when timers are being fired...

Hi @fatso83, is there anything more you need from me here? We feel like this is quite a powerful feature, unlocking all the benefits of a fast mock clock without...

@fatso83 I updated the commit to split the new "setTickMode" feature out from the new "nextAsync" mode. Hopefully this makes it easier to review (and apologies if you had pending...

@fatso83 Is there any existing/accepted way in the Sinon fake timers code to check if it's running in node? `setImmediate` is a pretty fairly significant improvement over `setTimeout`. I found...