Andrew Scott

Results 264 comments of Andrew Scott

> Seeing this hanging for such a long time is embarrassing, but I have almost not been touching JS for the last six months, so it's been hard justifying working...

IIUC, the tests rely on truly async behavior that cannot be mocked by sinon. For example, in [this test](https://github.com/nodejs/undici/blob/f59b663729557b780a99e7d44feecab4130fc785/test/retry-handler2.js#L46-L64), you can create a timeout error for the test by calling...

By the way, you can get the same behavior as the `setTimeout(() => clock.tick(100); timer.refresh();)` version with `autoTick`/`runAllAsync` by adding a no-op timer every 100ms `setTimeout(() => { timer.refresh(); },...

> Sorry for keeping it open for such a long time - hope you see why. No worries at all! As a maintainer of an open source library myself, I...

> so I will say "no scroll to the top" is the correct behavior. There really is no “correct behavior” with respect to scrolling on navigation, but is more a...

> If your wants to emulate MPAs, you should change the scrollTop by RouterScroller, not eventCoalescing: true Yes, there is absolutely an argument for enabling or recommending the router’s scrolling...

Closing in favor of canonical issue tracking consequences of macrotask-based scheduling (#57528)

This certainly will require a TGP and potentially require noting it as a breaking change

It seems like there are a lot of options here that are reasonable: * Nullish coalesce to `undefined`: `[input]="(myObservable$ | async) ?? undefined"` * Nullish coalesce to default value: `[input]="(myObservable$...

This PR was merged into the repository by commit 4e890cc5ac6eaa04a6f7ca988908812a65991c14. The changes were merged into the following branches: main