Andrew Scott

Results 264 comments of Andrew Scott

> In typical usage, would user code poll for some side effect of the timers that `advanceUntilModeChanges` triggers? Yes, exactly. This would allow writing unit test code in a way...

Just wanted to circle back and share some results of integrating this into the Angular Router tests (it took a while because we had some tooling updates necessary to update...

> I think you mentioned somewhere that this helps with the move to zoneless as well? Yes, indeed it does. Typically full zoneless would also include removing `fakeAsync` in the...

Am I understanding correctly that Zed does not allow two language servers to co-exist and provide functionality to the same file? If so, that feels like a much more fundamental...

@jpike88 got it. That’s an interesting discussion. The priority for which language server to use for renaming is an unsolved problem in VSCode https://github.com/microsoft/vscode/issues/115354. This is the reason we entirely...

Feel free to send a PR to update the documentation here: https://github.com/angular/angular/blob/main/adev/src/content/tools/language-service.md#angular-language-service-in-your-editor

Seems to be [this](https://stackoverflow.com/questions/66660266/why-does-firefox-add-horizontal-scroll-bars-once-vertical-ones-are-needed) problem. Changing overflow-y to "scroll" or overflow-x to "hidden" appears to resolve the issue https://github.com/angular/angular/blob/e50f8a23dcefe573ab738f329a1b49ae45e3ffc0/adev/src/app/features/update/update.component.scss#L32

> Is the behaviour of this new method different from the advanceTimers option? If so, perhaps it would be good to mention that in documentation? Good question! Yes, it's quite...

> Do I get it right that this new API is somewhat a variation of jest.advanceTimersToNextTimerAsync()? Yes, that's right! > I thought, perhaps instead of adding new one, it would...

> The idea I was talking about was to replace jest.setAdvanceTimersAutomatically(true) with jest.advanceTimersToNextTimerAsync('automatic') and setAdvanceTimersAutomatically(false) with jest.advanceTimersToNextTimerAsync('manual'). Or some such. Just an idea. Ah, you mean that it the automatic/manual...