nodejs
[v22.x backport] esm: implement import.meta.main
Should include https://github.com/nodejs/node/pull/58661 if it doesn't already
We should only pick the commits that have landed on main, this PR have 47 commits that are not on main
@aduh95 to adhere to the 'only commits that landed' rule, should I squash the new commits into a landed commit? or are commits for manual resolution after cherry-picking OK?
@aduh95 to adhere to the 'only commits that landed' rule, should I squash the new commits into a landed commit? or are commits for manual resolution after cherry-picking OK?
You can use git commit --fixup <commit-sha>, so it's easier to review and squash those additional commits upon landing.
What's the deal here? I don't understand why CI is failing 🤔
It looks like the Coverage CI is broken on that branch, unrelated to your changes. The macOS one timed out, also probably unrelated to your changes.
can you include https://github.com/nodejs/node/commit/bba07d7e1edace182894b517a903cb55fb4d5b2b in the backport (if lands cleanly otherwise I can open a backport)
can you include https://github.com/nodejs/node/commit/bba07d7e1edace182894b517a903cb55fb4d5b2b in the backport (if lands cleanly otherwise I can open a backport)
'In addition to' or 'instead of' d8d3b07 (which is currently included) ?
What's the deal here? I don't understand why CI is failing 🤔
It looks like the Coverage CI is broken on that branch, unrelated to your changes.
FWIW the broken Coverage Windows GitHub Workflow is the same breakage as https://github.com/nodejs/node/issues/58801 (and unrelated to this PR). cc FYI @nodejs/releasers
Something weird happened and I had to drop a couple of commits, then redo the rebase - let me know whether or not things look OK