node icon indicating copy to clipboard operation
node copied to clipboard

test_runner: prefer `Atomics` primordials

Open aduh95 opened this issue 6 months ago • 5 comments

Extracted from https://github.com/nodejs/node/pull/58577

aduh95 avatar Jun 15 '25 14:06 aduh95

Review requested:

  • [ ] @nodejs/test_runner

nodejs-github-bot avatar Jun 15 '25 14:06 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/67464/

nodejs-github-bot avatar Jun 15 '25 14:06 nodejs-github-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.16%. Comparing base (462c741) to head (ef2e084). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58716   +/-   ##
=======================================
  Coverage   90.15%   90.16%           
=======================================
  Files         639      639           
  Lines      188201   188195    -6     
  Branches    36915    36916    +1     
=======================================
+ Hits       169675   169679    +4     
+ Misses      11274    11273    -1     
+ Partials     7252     7243    -9     
Files with missing lines Coverage Δ
lib/internal/test_runner/mock/loader.js 95.58% <100.00%> (-0.09%) :arrow_down:
lib/internal/test_runner/mock/mock.js 99.27% <100.00%> (-0.01%) :arrow_down:

... and 33 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 15 '25 15:06 codecov[bot]

/cc @Renegade334 just in case.

LiviaMedeiros avatar Jun 15 '25 18:06 LiviaMedeiros

Thanks all.

Renegade334 avatar Jun 15 '25 18:06 Renegade334

Landed in ef2e0848ba36

aduh95 avatar Jun 17 '25 14:06 aduh95