allwpilib

allwpilib copied to clipboard

Supports USB, HTTP, and NT-published CameraServers.

PeterJohnson

CANcoder will be removed from Phoenix 5 for 2025 and beyond, so we should remove the CANcoder gain preset. 

DeltaDizzy

Problems Creating SelectCommand from lambda function and std::vector<std::pair<std::string, std::unique_ptr<frc2::Command>>>

1

I am trying to create a SelectCommand at runtime. The commands are created by reading a json file during RobotInit. Code: ``` #include #include frc2::CommandPtr createSelectCommand(std::function selector , std::vector &&commands)...

webbbt456

Prototype implementation: https://github.com/calcmogul/SysIdOpt/blob/main/src/Main.cpp#L122-L282

calcmogul

TrapezoidProfile methods (somewhat) incompatible with new API

2

**Describe the bug** Several of the methods in TrapezoidProfile have surprising behavior in some cases when used with the new (non-deprecated, single-argument) constructor because member variables they depend on are...

chauser

EllipticalRegionConstraint trajectory constraint rotates the wrong arguments

1

EllipticalRegionConstraint supports rotated ellipses. It attempts to do this by rotating the ellipse radii. This is incorrect because it resizes the ellipse with the same orientation. The correct thing to...

calcmogul

This is "strongly recommended" in the javadocs for the AutoCloseable.close(). See: https://docs.oracle.com/javase/8/docs/api/java/lang/AutoCloseable.html#close--

brettle

That behavior has not been present since PR #4158 was merged more than 2 years ago and imo should not be added back because it was surprising and not consistent...

brettle

Draft because the build currently fails with allwpilib main. It does pass for wpilib 2024.3.2: https://github.com/Beachbot330/allwpilib/actions/runs/9763284409/job/26951478424

sciencewhiz

It was broken in #2788. I don't see much utility in fixing this compared to just modifying hal/CMakeLists.txt to point to alternative HAL source files, especially because [a vendor](https://github.com/kauailabs/allwpilib/blob/master/hal/CMakeLists.txt) has...

Gold856