valentinewallace
valentinewallace
> also  for this function here would i need to create a new function to obtain the local balance Does this comment answer that: https://github.com/lightningdevkit/rust-lightning/issues/1898#issuecomment-1347474378 so just use `Channel::get_available_balances`?
I think I like (3a). That way we don't have to pass in a full mapping, there can just be an `scid_to_node_id` method on `NodeIdLookup`, and we can use `ChannelManager::short_to_chan_info`...
> The issue with extending OffersMessageHandler is that we also need the lookup for stand-alone functions (e.g, peel_onion_message). So better to use a dedicated trait, IMO. IMO peel_onion_message can just...
> What we do for create_onion_message which may call advance_path_by_one? I suppose we would want to make the scid on the second hop into an introduction node using an sciddir....
Could we rebase this on #2906? Hard to evaluate the new `OutboundTrampolinePayload` out of context
We may also eventually want utilities similar to `lightning-invoice::utils::create_invoice_from_channelmanager` that will automatically supply the payment hash and blinded payment paths
Discussed offline with Matt and want to get some conceptual feedback on this design to resolve the issue: 1. User provides a whitelist of nodes for which to store OM...
Discussed offline, going with the event-based approach for now rather than storing OMs internally in LDK. We won't be using a whitelist internally in LDK either, but users should keep...
IMO, the `node_counter` changes could be split off to make the PR more focused. At the moment there's a lot bundled in here with the cache updates, more minor `get_route`...