valentinewallace

Squashed in the new changes with the following diff: ```diff diff --git a/lightning/src/offers/signer.rs b/lightning/src/offers/signer.rs index d6372bca8..d8caa2175 100644 --- a/lightning/src/offers/signer.rs +++ b/lightning/src/offers/signer.rs @@ -44,7 +44,7 @@ const OFFER_PAYMENT_ID_HMAC_INPUT: &[u8; 16] =...

Oops, and a `rustfmt` fix: ```diff diff --git a/lightning/src/offers/static_invoice.rs b/lightning/src/offers/static_invoice.rs index d083cae88..4910c57c5 100644 --- a/lightning/src/offers/static_invoice.rs +++ b/lightning/src/offers/static_invoice.rs @@ -315,9 +315,11 @@ impl StaticInvoice { } pub(crate) fn from_same_offer(&self, invreq: &InvoiceRequest)...

~@joostjager helped me realize this may be way overcomplicated, essentially all tests pass on `main` when we simply read-and-discard the pending forwards maps. It's a bit suspicious though that all...

Updated with new testing and a few tweaks: [diff](https://github.com/lightningdevkit/rust-lightning/compare/0b4eb68cdcab3eb9fa900ec02561895bbc0ec26a..ce2ccac3a242f9b74b7d650f921a7c2517e61d6b) Will rebase next

I still need to finish adding some comments and responding to feedback, but I believe the tests are done and this should be mostly there so pushed up the latest...

> > I still need to finish adding some comments and responding to feedback, but I believe the tests are done and this should be mostly there so pushed up...

Thinking about the current approach in the last commit where we find a route -- I think things may be cleaner if we move a lot of the handling of...

Rebased due to conflicts, then pushed an additional typo fix: ```diff diff --git a/lightning/src/events/mod.rs b/lightning/src/events/mod.rs index bc7bbb641..823c5e2c2 100644 --- a/lightning/src/events/mod.rs +++ b/lightning/src/events/mod.rs @@ -566,7 +566,7 @@ pub enum PaymentFailureReason {...

I went ahead and squashed, the diff prior was: ```diff diff --git a/lightning/src/ln/outbound_payment.rs b/lightning/src/ln/outbound_payment.rs index c68209e8d..c3fde629a 100644 --- a/lightning/src/ln/outbound_payment.rs +++ b/lightning/src/ln/outbound_payment.rs @@ -954,7 +954,7 @@ impl OutboundPayments { let onion_session_privs...

@orbitalturtle does this work? I feel like I'm missing something since Matt said it was optimistic that this would make the release.