valentinewallace
valentinewallace
`rustfmt` check is failing
2c -- I agree that `InvoiceRequest::issuer_signing_pubkey` is a bit confusing. Tbh, I don't see an issue with using `payee` or `recipient` terminology, if we want to stick to just renames...
> > 2c -- I agree that `InvoiceRequest::issuer_signing_pubkey` is a bit confusing. Tbh, I don't see an issue with using `payee` or `recipient` terminology, if we want to stick to...
Needs rebase :( I did find the new testing not ideal from a readability PoV at first glance, going to take a closer look in a bit but let me...
LGTM after @TheBlueMatt takes another look
I added this assert and got a bunch of test failures. Are we intentionally overshooting on the invoice bytes capacity? It didn't seem like it to me but wanted to...
LGTM after @tnull's feedback is resolved (and it looks like this need rebase). Nice to have this testing infra!
Needs rebase since #3700 landed
FYI, looks like fixup commits weren't added prior to the rebase so it's hard to see what changed. I'm also generally fine with squashing in changes if the rebase is...
We may be able to remove the test `test_sync_async_persist_doesnt_hang` since it specifically covers async + sync persistence.