valentinewallace
valentinewallace
Looks like 1.63 builds are sad
LGTM after the comment about `Box` is removed.
Potentially relevant for async payments (cc #2298) as well, as LDK will need to know whether it is an often-offline sender/recipient when paying and generating offers respectively, as well as...
> Because this uses the existing `FeeEstimator` `MinAllowedAnchorChannelRemoteFee` and `MinAllowedNonAnchorChannelRemoteFee` values, setting them to 0/253 will disable this entirely including the existing force-closes from peers sending us low values. Are...
Basically LGTM pending 2nd reviewer. Needs rebase as well.
Fuzz is failing. Otherwise this is the same as #3034 so should be able to Just Land.
As discussed offline, we'll want to land a `cfg`-flagged version of this PR :)
So when I add a call to `get_secure_random_bytes` on startup, the test still fails. To fix #2827, you'll need to actually check out a different git commit of LDK linked...
> what should the type be for last_local_balance_msat field @TheBlueMatt @Cxxshyy should be `u64`!