valentinewallace

Updated in response to to @joostjager's comments. [Link to diff](https://github.com/lightningdevkit/rust-lightning/compare/918ed61197636b2d837d4b2c3f4136aa0d943769..ec93a1523141b00167ab48081ae3902162c784d3)

Rebased on main after #3639 landed

Clarified a few more docs I noticed. [Link to diff](https://github.com/lightningdevkit/rust-lightning/compare/7823551cc2a2c42fccda9dbaa9edcfc929db18f7..66d7b4fecc50450d30c31045ddef4e1e4abe919e) Edit: pushed another CI fix

Rebased after #3767 landed, haven't addressed feedback yet

Mostly updated, need to fix linting. I added fixups for a few things to call attention/add a short explanation. [Diff](https://github.com/lightningdevkit/rust-lightning/compare/128208fca87c93fbd00bb1ebdb9d45e87f732384..4f8d15cf8f1ed9a4d843de327a9aa20333c3ab86) Edit: fixed linting, [diff](https://github.com/lightningdevkit/rust-lightning/compare/4f8d15cf8f1ed9a4d843de327a9aa20333c3ab86..6fe5f86f7a512eea0de4cfa35a97d01ff814f350)

Addressed feedback with this [diff](https://github.com/lightningdevkit/rust-lightning/compare/6fe5f86f7a512eea0de4cfa35a97d01ff814f350..bfab61ce0931d39fe807ac0b17e54435007c9fbd)

Updated in response to feedback. Github isn't giving me a nice diff link so made a pastebin: https://pastebin.com/JyLVcLWZ

Rebased on due to conflicts

Pushed an overhaul of the PR based on discussions with @TheBlueMatt last week. [Diff](https://github.com/lightningdevkit/rust-lightning/compare/ae932008ec3719f3f0a2e35279bfae02267c6a9b..b7b83902204f641629357bc7731884e4fa55c899). Planning to discuss in more detail over a sync with @joostjager next week. Planning to push...

These are the items to save for follow-up PRs that I'm thinking: * support the server configuring how many invoices they'll persist for the user (currently it's hardcoded to 10)...