rust-lightning icon indicating copy to clipboard operation
rust-lightning copied to clipboard

Construct Trampoline onion from path.

Open arik-so opened this issue 1 year ago • 4 comments

arik-so avatar Mar 08 '24 23:03 arik-so

Thanks for the feedback, @TheBlueMatt! I'll update #2756 to reflect your recommendations.

arik-so avatar Mar 12 '24 17:03 arik-so

Could we rebase this on #2906? Hard to evaluate the new OutboundTrampolinePayload out of context

valentinewallace avatar Mar 27 '24 17:03 valentinewallace

Yeah, ish, but absent a Receive variant, it's gonna completely break, so I think once 2906 is in I'll need to rework this. Bastien has been very helpful with trampoline to blinded path serialization references, so I'll alter this PR to do that instead.

arik-so avatar Mar 27 '24 18:03 arik-so

Codecov Report

Attention: Patch coverage is 30.41475% with 151 lines in your changes are missing coverage. Please review.

Project coverage is 90.07%. Comparing base (ac9a2c8) to head (e768f53). Report is 39 commits behind head on main.

Files Patch % Lines
lightning/src/ln/onion_utils.rs 0.86% 114 Missing :warning:
lightning/src/ln/msgs.rs 50.94% 22 Missing and 4 partials :warning:
lightning/src/routing/router.rs 56.25% 7 Missing :warning:
lightning/src/events/mod.rs 25.00% 3 Missing :warning:
lightning-background-processor/src/lib.rs 0.00% 0 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2927      +/-   ##
==========================================
+ Coverage   89.42%   90.07%   +0.64%     
==========================================
  Files         117      118       +1     
  Lines       96290   104861    +8571     
  Branches    96290   104861    +8571     
==========================================
+ Hits        86109    94454    +8345     
- Misses       7962     8246     +284     
+ Partials     2219     2161      -58     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Apr 18 '24 23:04 codecov-commenter