valentinewallace
valentinewallace
@jkczyz did you want to rename `Offer::paths` now as well?
Rebased due to conflicts.
Had a rebase error, squashed change with the following diff: ```diff diff --git a/lightning/src/blinded_path/payment.rs b/lightning/src/blinded_path/payment.rs index 10d5d8de0..ca937c57d 100644 --- a/lightning/src/blinded_path/payment.rs +++ b/lightning/src/blinded_path/payment.rs @@ -201,8 +201,8 @@ pub struct ForwardTlvs {...
```diff diff --git a/fuzz/src/invoice_request_deser.rs b/fuzz/src/invoice_request_deser.rs index a5db1c4be..3abb0974e 100644 --- a/fuzz/src/invoice_request_deser.rs +++ b/fuzz/src/invoice_request_deser.rs @@ -113,6 +113,7 @@ fn build_response( htlc_minimum_msat: 100, }, features: BlindedHopFeatures::empty(), + next_blinding_override: None, }, node_id: pubkey(43), htlc_maximum_msat:...
> Hi there, I've solved this issue on my local repo. Just wanted to ask if I can make a PR right away or do I need to be assigned...
awesome, thanks @ariard . @TheBlueMatt i'm sure you've considered this, any reason we're not using `rustfmt` or something similar?
> is there a way to apply a formatter to just new code (ie format a commit) I could see that leading to some slightly weird-looking situations, like one newly-committed...
Thanks for the input @MaxFangX, we're still open to this so will put it on the next milestone! Would be helpful to know what priority level this is for y'all.
> Another use case is Fedimint, where they'll want to include their own payment hash in the `Bolt12Invoice`. Does Fedimint plan to use the `OffersMessageFlow` without a `ChannelManager`?