valentinewallace
valentinewallace
@joostjager not sure how authenticating dummy hops creates a timing attack? We'll fail on the first hop if an attacker creates a bogus path that fails authentication, which seems correct...
Would it be possible to rebase this on main so I can base #3618 on it more easily? 🙏
@jkczyz Not sure if you wanted to take a last look but FYI this should be getting pretty close to landing
Would like to get confirmation on one case -- In `test_bump_penalty_txn_on_revoked_commitment`, we have 1 revoked HTLC output where the counterparty can claim it at height 41 and another where the...
Will go through the commits in a bit more detail before taking this out of draft, but conceptual feedback or feedback on the protocol itself is welcome, or the way...
> Hmmm, I wonder if we shouldn't allow the client to cache N offers rather than only 1. I worry a bit about the privacy implications of having One Offer...
Going to base this on https://github.com/lightningdevkit/rust-lightning/pull/3640. Will finish updating the ser macros based on those changes and push updates here after finishing some review.
Pushed some updates after moving the async receive offer cache into the new `OffersMessageFlow` struct added in #3639.
Rebased on the latest version of #3639
Pushed some minor fixes for CI.