valentinewallace
valentinewallace
Addressed feedback and rebased due to merge conflicts, diff prior to rebase was: ```diff diff --git a/README.md b/README.md index bba6b55..2f8096a 100644 --- a/README.md +++ b/README.md @@ -25,3 +25,4 @@ For...
Thanks @t-bast, updated with this diff: ```diff diff --git a/blip-0025.md b/blip-0025.md index 3f032d7..a306ba4 100644 --- a/blip-0025.md +++ b/blip-0025.md @@ -20,12 +20,19 @@ This bLIP is licensed under the CC0 license....
> We had an interesting discussion in [#36 (comment)](https://github.com/lightning/blips/pull/36#discussion_r1665518804) that is related to this, it's probably worth a read. This isn't a no-go at all for me if you want...
Changed up the feature bits, required single-chain offers, and disallowed setting `invoice_amount_msat` for static invoices. Also moved away from the "keysend" language for clarity. These changes were based on implementing...
Added a fixup requiring the invreq to be included in the payment onion per spec meeting discussion a week ago!
Rebased after merge of #798 🎉
I found some more edge cases around how `get_route` counts hops as part of a path, so feel free to hold off on review there.
Rebased to (hopefully) fix CI. This should be good for review.
Feedback should be addressed. Also this needs a rebase so let me know when I can do that.
Squashed with 1 new fixup.